On Tue, Feb 19, 2013 at 04:19:52PM -0300, Paulo Zanoni wrote:
> Hi
>
> 2013/2/19 Daniel Vetter <daniel at ffwll.ch>:
> > On Mon, Feb 18, 2013 at 07:00:27PM -0300, Paulo Zanoni wrote:
> >> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> >>
> >> Some HDMI registers can be used for SDVO, so saying "HDMIB" should be
> >> the same as saying "SDVOB" for a given HW generation. This was not
> >> true and led to confusions and even a regression.
> >>
> >> Previously we had:
> >> - SDVO{B,C} defined as the Gen3+ registers
> >> - HDMI{B,C,D} and PCH_SDVOB defined as the PCH registers
> >>
> >> But now:
> >> - SDVO{B,C} became GEN3_SDVO{B,C} on SDVO code
> >> - SDVO{B,C} became GEN4_HDMI{B,C} on HDMI code
> >> - HDMI{B,C,D} became PCH_HDMI{B,C,D}
> >> - PCH_SDVOB is still the same thing
> >>
> >> v2: Rebase (v1 was sent in May 2012).
> >>
> >> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
> >
> > I think we still have a bit of ugly left in here, especially that the
> > register bit definitions are splattered all over irks me a bit. What about
> > moving the HDMI stuff up to the SDVO definitions and giving the HDMI bits
> > consisten HDMI_ prefixes? Imo there's no point in adding duplicate
> > #defines for all the SDVO_ bits we use in intel_hdmi.c ...
>
> I agree, there's more to clean up. I thought about amending your
> suggestions to this patch, but I don't think this will be a good idea,
> so I will send 3 additional patches on top of this one. Feel free to
> merge them as a single patch if you want.
I've merged all four patches to dinq, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
