Re: [igt-dev] [PATCH i-g-t v2] gem_wsim: Implement device selection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 17/11/2020 14:06, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2020-11-17 13:59:18)
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

-L and -D <device> on the command line.

With no device specified tool tries to find i915 discrete or integrated in
that order.

v2:
  * Fix error handling and support render devices.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Hmm, optarg should be a pointer into the argv, so is the copy necessary?

I don't remember if I tried, and I don't see that getopt(3) explains optarg from that angle, so probably safest to keep as is. Too lazy to try.. Or maybe presence of strdup suggests I did already try and that optarg is indeed temporary copy managed by getopt.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux