Re: [PATCH 05/27] drm/i915/pxp: Enable ioctl action to set the ring3 context (fwd)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

There is a problem on line 21 if i915 can actually be NULL.

julia

---------- Forwarded message ----------
Date: Sat, 14 Nov 2020 19:03:47 +0800
From: kernel test robot <lkp@xxxxxxxxx>
To: kbuild@xxxxxxxxxxxx
Cc: lkp@xxxxxxxxx, Julia Lawall <julia.lawall@xxxxxxx>
Subject: Re:  [PATCH 05/27] drm/i915/pxp: Enable ioctl action to set
    the ring3 context

CC: kbuild-all@xxxxxxxxxxxx
In-Reply-To: <20201114014537.25495-5-sean.z.huang@xxxxxxxxx>
References: <20201114014537.25495-5-sean.z.huang@xxxxxxxxx>
TO: Sean Z Huang <sean.z.huang@xxxxxxxxx>
TO: Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
CC: "Huang, Sean Z" <sean.z.huang@xxxxxxxxx>

Hi Sean,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20201113]
[also build test WARNING on v5.10-rc3]
[cannot apply to drm-intel/for-linux-next char-misc/char-misc-testing v5.10-rc3 v5.10-rc2 v5.10-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sean-Z-Huang/drm-i915-pxp-Introduce-Intel-PXP-component/20201114-094926
base:    92edc4aef86780a8ad01b092c6d6630bb3cb423d
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago
config: i386-randconfig-c001-20201113 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Reported-by: Julia Lawall <julia.lawall@xxxxxxx>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/gpu/drm/i915/pxp/intel_pxp.c:21:17-20: ERROR: i915 is NULL but dereferenced.

vim +21 drivers/gpu/drm/i915/pxp/intel_pxp.c

a9c9ffc6ce4f8b0 Huang, Sean Z 2020-11-13  10
1d109ada10e82c3 Huang, Sean Z 2020-11-13  11  int i915_pxp_ops_ioctl(struct drm_device *dev, void *data, struct drm_file *drmfile)
1d109ada10e82c3 Huang, Sean Z 2020-11-13  12  {
1d109ada10e82c3 Huang, Sean Z 2020-11-13  13  	int ret;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  14  	struct pxp_info pxp_info = {0};
1d109ada10e82c3 Huang, Sean Z 2020-11-13  15  	struct drm_i915_pxp_ops *pxp_ops = data;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  16  	struct drm_i915_private *i915 = to_i915(dev);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  17
1d109ada10e82c3 Huang, Sean Z 2020-11-13  18  	drm_dbg(&i915->drm, ">>> %s\n", __func__);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  19
1d109ada10e82c3 Huang, Sean Z 2020-11-13  20  	if (!i915 || !drmfile || !pxp_ops || pxp_ops->pxp_info_size != sizeof(pxp_info)) {
1d109ada10e82c3 Huang, Sean Z 2020-11-13 @21  		drm_dbg(&i915->drm, "Failed to %s, invalid params\n", __func__);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  22  		ret = -EINVAL;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  23  		goto end;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  24  	}
1d109ada10e82c3 Huang, Sean Z 2020-11-13  25
1d109ada10e82c3 Huang, Sean Z 2020-11-13  26  	if (copy_from_user(&pxp_info, (void __user *)pxp_ops->pxp_info_ptr, sizeof(pxp_info)) != 0) {
1d109ada10e82c3 Huang, Sean Z 2020-11-13  27  		ret = -EFAULT;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  28  		goto end;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  29  	}
1d109ada10e82c3 Huang, Sean Z 2020-11-13  30
1d109ada10e82c3 Huang, Sean Z 2020-11-13  31  	drm_dbg(&i915->drm, "i915 pxp ioctl call with action=[%d]\n", pxp_info.action);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  32
1d109ada10e82c3 Huang, Sean Z 2020-11-13  33  	mutex_lock(&i915->pxp.r0ctx->ctx_mutex);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  34
1d109ada10e82c3 Huang, Sean Z 2020-11-13  35  	if (i915->pxp.r0ctx->global_state_in_suspend) {
1d109ada10e82c3 Huang, Sean Z 2020-11-13  36  		drm_dbg(&i915->drm, "Return failure due to state in suspend\n");
1d109ada10e82c3 Huang, Sean Z 2020-11-13  37  		pxp_info.sm_status = PXP_SM_STATUS_SESSION_NOT_AVAILABLE;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  38  		ret = 0;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  39  		goto end;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  40  	}
1d109ada10e82c3 Huang, Sean Z 2020-11-13  41
1d109ada10e82c3 Huang, Sean Z 2020-11-13  42  	if (i915->pxp.r0ctx->global_state_attacked) {
1d109ada10e82c3 Huang, Sean Z 2020-11-13  43  		drm_dbg(&i915->drm, "Retry required due to state attacked\n");
1d109ada10e82c3 Huang, Sean Z 2020-11-13  44  		pxp_info.sm_status = PXP_SM_STATUS_RETRY_REQUIRED;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  45  		ret = 0;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  46  		goto end;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  47  	}
1d109ada10e82c3 Huang, Sean Z 2020-11-13  48
1d109ada10e82c3 Huang, Sean Z 2020-11-13  49  	switch (pxp_info.action) {
1d109ada10e82c3 Huang, Sean Z 2020-11-13  50  	case PXP_ACTION_SET_R3_CONTEXT:
1d109ada10e82c3 Huang, Sean Z 2020-11-13  51  	{
1d109ada10e82c3 Huang, Sean Z 2020-11-13  52  		ret = intel_pxp_set_r3ctx(i915, pxp_info.set_r3ctx);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  53  		break;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  54  	}
1d109ada10e82c3 Huang, Sean Z 2020-11-13  55  	default:
1d109ada10e82c3 Huang, Sean Z 2020-11-13  56  		drm_dbg(&i915->drm, "Failed to %s due to bad params\n", __func__);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  57  		ret = -EINVAL;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  58  		goto end;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  59  	}
1d109ada10e82c3 Huang, Sean Z 2020-11-13  60
1d109ada10e82c3 Huang, Sean Z 2020-11-13  61  end:
1d109ada10e82c3 Huang, Sean Z 2020-11-13  62  	mutex_unlock(&i915->pxp.r0ctx->ctx_mutex);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  63
1d109ada10e82c3 Huang, Sean Z 2020-11-13  64  	if (ret == 0)
1d109ada10e82c3 Huang, Sean Z 2020-11-13  65  		if (copy_to_user((void __user *)pxp_ops->pxp_info_ptr, &pxp_info, sizeof(pxp_info)) != 0)
1d109ada10e82c3 Huang, Sean Z 2020-11-13  66  			ret = -EFAULT;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  67
1d109ada10e82c3 Huang, Sean Z 2020-11-13  68  	if (ret)
1d109ada10e82c3 Huang, Sean Z 2020-11-13  69  		dev_err(&dev->pdev->dev, "pid=%d, ret = %d\n", task_pid_nr(current), ret);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  70
1d109ada10e82c3 Huang, Sean Z 2020-11-13  71  	drm_dbg(&i915->drm, "<<< %s\n", __func__);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  72  	return ret;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  73  }
1d109ada10e82c3 Huang, Sean Z 2020-11-13  74

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux