== Series Details == Series: series starting with [1/2] drm/i915/display: Support PSR Multiple Transcoders URL : https://patchwork.freedesktop.org/series/83382/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4a0e36485e2f drm/i915/display: Support PSR Multiple Transcoders -:207: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #207: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:428: } +static int i915_edp_psr_status(struct seq_file *m, void *data) -:247: WARNING:LINE_SPACING: Missing a blank line after declarations #247: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:464: + struct intel_dp *intel_dp = enc_to_intel_dp(encoder); + if (!CAN_PSR(intel_dp)) -:315: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #315: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1290: + struct mutex lock; -:331: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #331: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1306: + unsigned busy_frontbuffer_bits; -:852: WARNING:LONG_LINE: line length of 111 exceeds 100 columns #852: FILE: drivers/gpu/drm/i915/display/intel_psr.c:870: + intel_de_read(dev_priv, EDP_PSR2_CTL(intel_dp->psr.transcoder)) & EDP_PSR2_ENABLE); -:858: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #858: FILE: drivers/gpu/drm/i915/display/intel_psr.c:873: + intel_de_read(dev_priv, EDP_PSR_CTL(intel_dp->psr.transcoder)) & EDP_PSR_ENABLE); -:1748: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_dp' - possible side-effects? #1748: FILE: drivers/gpu/drm/i915/display/intel_psr.h:21: +#define CAN_PSR(intel_dp) (HAS_PSR(dp_to_i915(intel_dp)) && intel_dp->psr.sink_support) -:1757: ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1757: FILE: drivers/gpu/drm/i915/display/intel_psr.h:31: +int intel_psr_debug_set(struct intel_dp* intel_dp, u64 value); total: 1 errors, 4 warnings, 3 checks, 1789 lines checked 7018d6e83b98 drm/i915/display: Support Multiple Transcoders' PSR status on debugfs -:50: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #50: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2288: + debugfs_create_file("i915_psr_status", S_IRUGO, root, total: 0 errors, 1 warnings, 0 checks, 35 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
