Re: [PATCH] drm/i915/dg1: Fix unbalanced braces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 27, 2020 at 5:06 PM Lucas De Marchi
<lucas.demarchi@xxxxxxxxx> wrote:
>
> Missing braces after rebase and surprisingly not caught by checkpatch.
>
> Fixes: 229f31e2d370 ("drm/i915/dg1: add hpd interrupt handling")
> Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/i915_irq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index dc33c96d741d..9087fff662c3 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -3666,9 +3666,9 @@ static void icp_irq_postinstall(struct drm_i915_private *dev_priv)
>         gen3_assert_iir_is_zero(&dev_priv->uncore, SDEIIR);
>         I915_WRITE(SDEIMR, ~mask);
>
> -       if (HAS_PCH_DG1(dev_priv))
> +       if (HAS_PCH_DG1(dev_priv)) {
>                 icp_ddi_hpd_detection_setup(dev_priv, DG1_DDI_HPD_ENABLE_MASK);
> -       else if (HAS_PCH_TGP(dev_priv)) {
> +       } else if (HAS_PCH_TGP(dev_priv)) {

actually this will go away soon when
https://patchwork.freedesktop.org/patch/396744/?series=82411&rev=4 is
merged, so this patch can be ignored.

Lucas De Marchi

>                 icp_ddi_hpd_detection_setup(dev_priv, TGP_DDI_HPD_ENABLE_MASK);
>                 icp_tc_hpd_detection_setup(dev_priv, TGP_TC_HPD_ENABLE_MASK);
>         } else if (HAS_PCH_JSP(dev_priv)) {
> --
> 2.29.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux