On Mon, 26 Oct 2020, Lucas De Marchi <lucas.demarchi@xxxxxxxxx> wrote: > First check in the function is if swsci() is supported. All the error > paths are easy to figure out the reason, so remove the extra debug > message: it's normal not to support swsci() e.g. in dgfx. > > v2: Rather than special case dgfx, just remove the debug message > (from Ville) > > Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_opregion.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c > index de995362f428..4f77cf849171 100644 > --- a/drivers/gpu/drm/i915/display/intel_opregion.c > +++ b/drivers/gpu/drm/i915/display/intel_opregion.c > @@ -1007,12 +1007,8 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv) > int ret; > > ret = swsci(dev_priv, SWSCI_GBDA_PANEL_DETAILS, 0x0, &panel_details); > - if (ret) { > - drm_dbg_kms(&dev_priv->drm, > - "Failed to get panel details from OpRegion (%d)\n", > - ret); > + if (ret) > return ret; > - } > > ret = (panel_details >> 8) & 0xff; > if (ret > 0x10) { -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx