Op 21-10-2020 om 16:44 schreef Chris Wilson: > Quoting Maarten Lankhorst (2020-10-21 15:39:48) >> Instead of sharing pages with breadcrumbs, give each timeline a >> single page. This allows unrelated timelines not to share locks >> any more during command submission. > This is designed to fail. No. The hwsp is observed externally with a > lifetime outside of the local timeline's control. > -Chris Hey, Thank you for looking at the patch. It seems you're worried about lifetime issues. When the timeline is pinned, i915_active takes a reference on the vma pin and timeline. intel_timeline_read_hwsp() uses the existing i915_active trick to keep the timeline alive, so this will stay working correctly as intended. :) Can I add your reviewed-by for the patch when I submit it to the ml again? Cheers, ~Maarten _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
