On Mon, Oct 19, 2020 at 02:34:07PM +0300, Jani Nikula wrote: > On Fri, 16 Oct 2020, "Navare, Manasi" <manasi.d.navare@xxxxxxxxx> wrote: > > I really want to push back on any design changes at this point since we have a working solution > > and we currently dont have any special cases. Like I discussed with you all the commit modeset enables > > code is now generic and similar to 2p2p. > > These kind of changes/ optimizations can be done later. Like you suggested we should get the basic working > > solution and support in. > > Like I said in [1], this is a big scary patch that has been reported to > break DSI VDSC. I tried to skim through it, but it's really impossible > to identify the one thing that could break DSI. > > I mean, even if you had the hardware to test, it could take days to > identify the regressing part here. > > And this isn't really specific to DSI, but rather to *any* regression > this might cause. Afterwards, would you stand a chance of telling what > goes wrong if you get a bisect result? Yes I agree, it took me ages to understand and inherit this patch from Maarten. I will try to split this patch into multiple small patches in my next rev. Manasi > > > BR, > Jani. > > > [1] http://lore.kernel.org/r/87o8l5awvr.fsf@xxxxxxxxx > > > -- > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
