== Series Details == Series: drm/i915: Remove obj->mm.lock! (rev10) URL : https://patchwork.freedesktop.org/series/82337/ State : warning == Summary == $ dim checkpatch origin/drm-tip f559c8e6c1e1 drm/i915: Move cmd parser pinning to execbuffer fd1c6790339e drm/i915: Add missing -EDEADLK handling to execbuf pinning -:47: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #47: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:452: + err = i915_vma_pin_ww(vma, &eb->ww, entry->pad_to_size, total: 0 errors, 0 warnings, 1 checks, 54 lines checked cdb7097261d7 drm/i915: Do not share hwsp across contexts any more, v5. -:518: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #518: FILE: drivers/gpu/drm/i915/gt/intel_timeline.c:296: + if (tl && (i915_request_completed(from) || + !kref_get_unless_zero(&tl->kref))) total: 0 errors, 0 warnings, 1 checks, 628 lines checked a32aadf1947f drm/i915: Pin timeline map after first timeline pin, v3. -:13: WARNING:TYPO_SPELLING: 'arithmatic' may be misspelled - perhaps 'arithmetic'? #13: - Fix NULL + XX arithmatic, use casts. (kbuild) total: 0 errors, 1 warnings, 0 checks, 295 lines checked 88d89a0244a0 drm/i915: Ensure we hold the object mutex in pin correctly. 1c39ebfaa050 drm/i915: Add gem object locking to madvise. 36de3e911aff drm/i915: Move HAS_STRUCT_PAGE to obj->flags -:106: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #106: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:63: + struct lock_class_key *key, unsigned flags) -:129: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #129: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:27: + unsigned alloc_flags); total: 0 errors, 2 warnings, 0 checks, 348 lines checked 1e84fb47ed9f drm/i915: Rework struct phys attachment handling ef5fc449bb58 drm/i915: Convert i915_gem_object_attach_phys() to ww locking 996a8929b824 drm/i915: make lockdep slightly happier about execbuf. fbe1d4c0257e drm/i915: Disable userptr pread/pwrite support. e283b29660e7 drm/i915: No longer allow exporting userptr through dma-buf c7cb9297e019 drm/i915: Reject more ioctls for userptr -:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7: set_tiling and set_caching are rejected with -ENXIO, there's no valid reason total: 0 errors, 1 warnings, 0 checks, 39 lines checked cfac37ac0a95 drm/i915: Reject UNSYNCHRONIZED for userptr 7e1cdef24fda drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v4. -:280: WARNING:LONG_LINE: line length of 121 exceeds 100 columns #280: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:555: +static inline int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; } -:281: WARNING:LONG_LINE: line length of 121 exceeds 100 columns #281: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:556: +static inline int i915_gem_object_userptr_submit_done(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; } -:282: WARNING:LONG_LINE: line length of 106 exceeds 100 columns #282: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:557: +static inline void i915_gem_object_userptr_submit_fini(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); } -:340: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #340: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:2: * SPDX-License-Identifier: MIT -:344: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #344: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:6: + * + * Based on amdgpu_mn, which bears the following notice: -:345: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #345: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:7: + * Based on amdgpu_mn, which bears the following notice: + * -:492: WARNING:LONG_LINE: line length of 106 exceeds 100 columns #492: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:63: + struct drm_i915_gem_object *obj = container_of(mni, struct drm_i915_gem_object, userptr.notifier); -:1110: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #1110: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:287: + pinned = ret = 0; -:1125: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1125: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:302: + if (mmu_interval_read_retry(&obj->userptr.notifier, + !obj->userptr.page_ref ? notifier_seq : -:1246: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #1246: FILE: drivers/gpu/drm/i915/i915_drv.h:597: + spinlock_t notifier_lock; total: 0 errors, 7 warnings, 3 checks, 1193 lines checked 484ac2e3e0b6 drm/i915: Flatten obj->mm.lock 37f08d1de510 drm/i915: Populate logical context during first pin. -:176: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #176: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:5531: +virtual_context_pre_pin(struct intel_context *ce, + struct i915_gem_ww_ctx *ww, void **vaddr) total: 0 errors, 0 warnings, 1 checks, 169 lines checked 5318a1dac4d4 drm/i915: Make ring submission compatible with obj->mm.lock removal, v2. e67277a7b097 drm/i915: Handle ww locking in init_status_page 6af827c60c60 drm/i915: Rework clflush to work correctly without obj->mm.lock. 57c03b8d7f68 drm/i915: Pass ww ctx to intel_pin_to_display_plane 1b5060c11695 drm/i915: Add object locking to vm_fault_cpu 2a7ce2e41ea1 drm/i915: Move pinning to inside engine_wa_list_verify() -:53: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #53: FILE: drivers/gpu/drm/i915/gt/intel_workarounds.c:2207: + err = i915_vma_pin_ww(vma, &ww, 0, 0, + i915_vma_is_ggtt(vma) ? PIN_GLOBAL : PIN_USER); total: 0 errors, 0 warnings, 1 checks, 109 lines checked c7f386c8a071 drm/i915: Take reservation lock around i915_vma_pin. 76b560a1a45a drm/i915: Make intel_init_workaround_bb more compatible with ww locking. f98bc085f8a1 drm/i915: Make __engine_unpark() compatible with ww locking. 2e1d8e358498 drm/i915: Take obj lock around set_domain ioctl da966f332f83 drm/i915: Defer pin calls in buffer pool until first use by caller. 0fc4ea9ba7b6 drm/i915: Fix pread/pwrite to work with new locking rules. -:28: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #28: deleted file mode 100644 total: 0 errors, 1 warnings, 0 checks, 401 lines checked c18316ca0319 drm/i915: Fix workarounds selftest, part 1 f5f320e70f10 drm/i915: Prepare for obj->mm.lock removal -:131: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author '"Thomas Hellström" <thomas.hellstrom@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 96 lines checked 3d4a256cdf8c drm/i915: Add igt_spinner_pin() to allow for ww locking around spinner. a02ed25df605 drm/i915: Add ww locking around vm_access() 491ec59fa0f3 drm/i915: Increase ww locking for perf. e547a3f5d7cf drm/i915: Lock ww in ucode objects correctly be60364681f4 drm/i915: Add ww locking to dma-buf ops. 924e9f0e0ded drm/i915: Add missing ww lock in intel_dsb_prepare. 132031dfaac0 drm/i915: Fix ww locking in shmem_create_from_object 46e5a7cf8b36 drm/i915: Use a single page table lock for each gtt. -:108: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #108: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:85: + return i915_gem_object_lock(vm->scratch[0], ww); + } else { total: 0 errors, 1 warnings, 0 checks, 154 lines checked f723410c1840 drm/i915/selftests: Prepare huge_pages testcases for obj->mm.lock removal. b5d97b6b92a2 drm/i915/selftests: Prepare client blit for obj->mm.lock removal. 450efdb3b6e5 drm/i915/selftests: Prepare coherency tests for obj->mm.lock removal. 0698353336eb drm/i915/selftests: Prepare context tests for obj->mm.lock removal. 491ae6d66428 drm/i915/selftests: Prepare dma-buf tests for obj->mm.lock removal. 25e0f16a49a3 drm/i915/selftests: Prepare execbuf tests for obj->mm.lock removal. 97f924c03247 drm/i915/selftests: Prepare mman testcases for obj->mm.lock removal. d5368fe4403e drm/i915/selftests: Prepare object tests for obj->mm.lock removal. 572cebd80c43 drm/i915/selftests: Prepare object blit tests for obj->mm.lock removal. 2aea11ba9a17 drm/i915/selftests: Prepare igt_gem_utils for obj->mm.lock removal 483372599ffd drm/i915/selftests: Prepare context selftest for obj->mm.lock removal 9efa81ca6a38 drm/i915/selftests: Prepare hangcheck for obj->mm.lock removal 14772bc7b669 drm/i915/selftests: Prepare execlists for obj->mm.lock removal -:155: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #155: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5857: + lrc = i915_gem_object_pin_map_unlocked(ce->state->obj, i915_coherent_map_type(engine->i915)); total: 0 errors, 0 warnings, 1 checks, 130 lines checked ba5a3e576413 drm/i915/selftests: Prepare mocs tests for obj->mm.lock removal b6fdfa7d55f7 drm/i915/selftests: Prepare ring submission for obj->mm.lock removal 87509d8f908e drm/i915/selftests: Prepare timeline tests for obj->mm.lock removal 6f7e43c69354 drm/i915/selftests: Prepare i915_request tests for obj->mm.lock removal 19e36d85a769 drm/i915/selftests: Prepare memory region tests for obj->mm.lock removal 8a1e7a1d42b7 drm/i915/selftests: Prepare cs engine tests for obj->mm.lock removal 5462aa34d8c6 drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal 3be3289e6d62 drm/i915: Finally remove obj->mm.lock. bcf18162657a drm/i915: Keep userpointer bindings if seqcount is unchanged, v2. _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
