== Series Details == Series: drm/i915: Remove obj->mm.lock! (rev3) URL : https://patchwork.freedesktop.org/series/82337/ State : warning == Summary == $ dim checkpatch origin/drm-tip 80a8f48f229f drm/i915: Move cmd parser pinning to execbuffer 85953c769887 drm/i915: Add missing -EDEADLK handling to execbuf pinning -:47: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #47: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:452: + err = i915_vma_pin_ww(vma, &eb->ww, entry->pad_to_size, total: 0 errors, 0 warnings, 1 checks, 54 lines checked d304ddd05bc2 drm/i915: Do not share hwsp across contexts any more, v3. -:500: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #500: FILE: drivers/gpu/drm/i915/gt/intel_timeline.c:291: + if (tl && (i915_request_completed(from) || + !i915_active_acquire_if_busy(&tl->active))) total: 0 errors, 0 warnings, 1 checks, 610 lines checked afc484a312e1 drm/i915: Pin timeline map after first timeline pin, v3. -:13: WARNING:TYPO_SPELLING: 'arithmatic' may be misspelled - perhaps 'arithmetic'? #13: - Fix NULL + XX arithmatic, use casts. (kbuild) total: 0 errors, 1 warnings, 0 checks, 293 lines checked 5204c04e1783 drm/i915: Ensure we hold the object mutex in pin correctly. 3078927638f1 drm/i915: Add gem object locking to madvise. f59341469336 drm/i915: Move HAS_STRUCT_PAGE to obj->flags -:106: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #106: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:63: + struct lock_class_key *key, unsigned flags) -:129: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #129: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:27: + unsigned alloc_flags); total: 0 errors, 2 warnings, 0 checks, 348 lines checked a0e592a97856 drm/i915: Rework struct phys attachment handling 174f857c33e0 drm/i915: Convert i915_gem_object_attach_phys() to ww locking 6f0824c8b9c0 drm/i915: make lockdep slightly happier about execbuf. 371cbc9d8c27 drm/i915: Disable userptr pread/pwrite support. 942724c1e6a7 drm/i915: No longer allow exporting userptr through dma-buf 415cc556a463 drm/i915: Reject more ioctls for userptr -:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7: set_tiling and set_caching are rejected with -ENXIO, there's no valid reason total: 0 errors, 1 warnings, 0 checks, 39 lines checked 6f485e50888c drm/i915: Reject UNSYNCHRONIZED for userptr 733050ed7f31 drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v3. -:276: WARNING:LONG_LINE: line length of 121 exceeds 100 columns #276: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:555: +static inline int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; } -:277: WARNING:LONG_LINE: line length of 121 exceeds 100 columns #277: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:556: +static inline int i915_gem_object_userptr_submit_done(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; } -:278: WARNING:LONG_LINE: line length of 106 exceeds 100 columns #278: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:557: +static inline void i915_gem_object_userptr_submit_fini(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); } -:336: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #336: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:2: * SPDX-License-Identifier: MIT -:340: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #340: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:6: + * + * Based on amdgpu_mn, which bears the following notice: -:341: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #341: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:7: + * Based on amdgpu_mn, which bears the following notice: + * -:488: WARNING:LONG_LINE: line length of 106 exceeds 100 columns #488: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:63: + struct drm_i915_gem_object *obj = container_of(mni, struct drm_i915_gem_object, userptr.notifier); -:1102: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #1102: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:282: + pinned = ret = 0; -:1116: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1116: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:296: + if (mmu_interval_read_retry(&obj->userptr.notifier, + !obj->userptr.page_ref ? notifier_seq : -:1235: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #1235: FILE: drivers/gpu/drm/i915/i915_drv.h:597: + spinlock_t notifier_lock; total: 0 errors, 7 warnings, 3 checks, 1186 lines checked f71980dabbdf drm/i915: Flatten obj->mm.lock 0ddefffcf870 drm/i915: Populate logical context during first pin. -:176: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #176: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:5523: +virtual_context_pre_pin(struct intel_context *ce, + struct i915_gem_ww_ctx *ww, void **vaddr) total: 0 errors, 0 warnings, 1 checks, 169 lines checked 372d3f54f47f drm/i915: Make ring submission compatible with obj->mm.lock removal, v2. 75e706407c5e drm/i915: Handle ww locking in init_status_page a5600bf6d23a drm/i915: Rework clflush to work correctly without obj->mm.lock. 8e3b1eed034a drm/i915: Pass ww ctx to intel_pin_to_display_plane 8623814b93d2 drm/i915: Add object locking to vm_fault_cpu 5c4f1b8547df drm/i915: Move pinning to inside engine_wa_list_verify() -:53: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #53: FILE: drivers/gpu/drm/i915/gt/intel_workarounds.c:2140: + err = i915_vma_pin_ww(vma, &ww, 0, 0, + i915_vma_is_ggtt(vma) ? PIN_GLOBAL : PIN_USER); total: 0 errors, 0 warnings, 1 checks, 109 lines checked 605d60eb1494 drm/i915: Take reservation lock around i915_vma_pin. 7aa2b4b7eab9 drm/i915: Make intel_init_workaround_bb more compatible with ww locking. 52f4f0994829 drm/i915: Make __engine_unpark() compatible with ww locking. ec1d61a7843a drm/i915: Take obj lock around set_domain ioctl a28dce1923d9 drm/i915: Defer pin calls in buffer pool until first use by caller. 6728383c5033 drm/i915: Fix pread/pwrite to work with new locking rules. -:28: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #28: deleted file mode 100644 total: 0 errors, 1 warnings, 0 checks, 401 lines checked e648311856d5 drm/i915: Fix workarounds selftest, part 1 9d404723b28b drm/i915: Prepare for obj->mm.lock removal -:131: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author '"Thomas Hellström" <thomas.hellstrom@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 96 lines checked 2f504829281d drm/i915: Add igt_spinner_pin() to allow for ww locking around spinner. d220a1bf467a drm/i915: Add ww locking around vm_access() 1676bdc1ed2e drm/i915: Increase ww locking for perf. 78cf25d2059c drm/i915: Lock ww in ucode objects correctly 38dfd5400402 drm/i915: Add ww locking to dma-buf ops. 929b4826615b drm/i915: Add missing ww lock in intel_dsb_prepare. ead477c41e05 drm/i915: Fix ww locking in shmem_create_from_object d9cbec998e7d drm/i915: Use a single page table lock for each gtt. -:108: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #108: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:85: + return i915_gem_object_lock(vm->scratch[0], ww); + } else { total: 0 errors, 1 warnings, 0 checks, 154 lines checked c444c91b2ab0 drm/i915/selftests: Prepare huge_pages testcases for obj->mm.lock removal. 4164fa6a8f49 drm/i915/selftests: Prepare client blit for obj->mm.lock removal. ec19378542fb drm/i915/selftests: Prepare coherency tests for obj->mm.lock removal. 7e0846ca1737 drm/i915/selftests: Prepare context tests for obj->mm.lock removal. 78c5bb187f6b drm/i915/selftests: Prepare dma-buf tests for obj->mm.lock removal. 790863ab8235 drm/i915/selftests: Prepare execbuf tests for obj->mm.lock removal. bf606ed2df1e drm/i915/selftests: Prepare mman testcases for obj->mm.lock removal. f54ecd6bac1c drm/i915/selftests: Prepare object tests for obj->mm.lock removal. 957fd6d746ac drm/i915/selftests: Prepare object blit tests for obj->mm.lock removal. 51748645f2d5 drm/i915/selftests: Prepare igt_gem_utils for obj->mm.lock removal ae7debf30f00 drm/i915/selftests: Prepare context selftest for obj->mm.lock removal b5831f57952b drm/i915/selftests: Prepare hangcheck for obj->mm.lock removal 2d5a80056c2e drm/i915/selftests: Prepare execlists for obj->mm.lock removal -:155: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #155: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5857: + lrc = i915_gem_object_pin_map_unlocked(ce->state->obj, i915_coherent_map_type(engine->i915)); total: 0 errors, 0 warnings, 1 checks, 130 lines checked 428290f8289c drm/i915/selftests: Prepare mocs tests for obj->mm.lock removal 0481554c6894 drm/i915/selftests: Prepare ring submission for obj->mm.lock removal 853948ea51a4 drm/i915/selftests: Prepare timeline tests for obj->mm.lock removal 3c9c1a5ddaff drm/i915/selftests: Prepare i915_request tests for obj->mm.lock removal c081d7e17c8b drm/i915/selftests: Prepare memory region tests for obj->mm.lock removal 4df2c5801bef drm/i915/selftests: Prepare cs engine tests for obj->mm.lock removal 135e45899449 drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal d48f071fd0db drm/i915: Finally remove obj->mm.lock. ffa7eb948163 drm/i915: Keep userpointer bindings if seqcount is unchanged, v2. 9ff2dbec02c1 drm/i915: Idea to implement eviction locking -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:63: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #63: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:175: + if (obj == list_first_entry(&ww->eviction_list, struct drm_i915_gem_object, obj_link)) { -:132: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #132: FILE: drivers/gpu/drm/i915/i915_gem.c:1383: + while ((obj = list_first_entry_or_null(&ww->eviction_list, struct drm_i915_gem_object, obj_link))) { -:149: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #149: FILE: drivers/gpu/drm/i915/i915_gem.c:1401: + while ((obj = list_first_entry_or_null(&ww->eviction_list, struct drm_i915_gem_object, obj_link))) { -:165: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 14) #165: FILE: drivers/gpu/drm/i915/i915_gem.c:1438: + else if (ret && ww->evicting) { + i915_gem_object_put(ww->contended); -:165: WARNING:BRACES: braces {} are not necessary for single statement blocks #165: FILE: drivers/gpu/drm/i915/i915_gem.c:1438: + else if (ret && ww->evicting) { + i915_gem_object_put(ww->contended); + } total: 0 errors, 6 warnings, 0 checks, 160 lines checked 61cd49cc7f1d drm/i915: Keep lazy reference to userptr pages -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 75 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
