== Series Details == Series: drm/i915: Remove obj->mm.lock! (rev2) URL : https://patchwork.freedesktop.org/series/82337/ State : warning == Summary == $ dim checkpatch origin/drm-tip ad5a5f0624eb drm/i915: Move cmd parser pinning to execbuffer f524499cf8c7 drm/i915: Add missing -EDEADLK handling to execbuf pinning -:47: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #47: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:452: + err = i915_vma_pin_ww(vma, &eb->ww, entry->pad_to_size, total: 0 errors, 0 warnings, 1 checks, 54 lines checked d968753cabcd drm/i915: Do not share hwsp across contexts any more, v3. -:500: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #500: FILE: drivers/gpu/drm/i915/gt/intel_timeline.c:292: + if (tl && (i915_request_completed(from) || + !i915_active_acquire_if_busy(&tl->active))) total: 0 errors, 0 warnings, 1 checks, 611 lines checked 930bd5654347 drm/i915: Ensure we hold the object mutex in pin correctly. 6360b8ee9c2e drm/i915: Add gem object locking to madvise. cfd65d6c3cad drm/i915: Move HAS_STRUCT_PAGE to obj->flags -:106: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #106: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:63: + struct lock_class_key *key, unsigned flags) -:129: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #129: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:27: + unsigned alloc_flags); total: 0 errors, 2 warnings, 0 checks, 348 lines checked f9fc09dae4ce drm/i915: Rework struct phys attachment handling 17d0c0aef20f drm/i915: Convert i915_gem_object_attach_phys() to ww locking d82af28768ae drm/i915: make lockdep slightly happier about execbuf. 84b4313f5488 drm/i915: Disable userptr pread/pwrite support. d506fc3aa2ed drm/i915: No longer allow exporting userptr through dma-buf 9f6c05f13de3 drm/i915: Reject more ioctls for userptr -:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7: set_tiling and set_caching are rejected with -ENXIO, there's no valid reason total: 0 errors, 1 warnings, 0 checks, 39 lines checked 55ecb181e541 drm/i915: Reject UNSYNCHRONIZED for userptr 353f6c46c4bf drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v2. -:163: ERROR:ASSIGN_IN_IF: do not use assignment in if condition #163: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2250: + if (!err && (eb->args->flags & __EXEC_USERPTR_USED) && -:271: WARNING:LONG_LINE: line length of 121 exceeds 100 columns #271: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:555: +static inline int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; } -:272: WARNING:LONG_LINE: line length of 121 exceeds 100 columns #272: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:556: +static inline int i915_gem_object_userptr_submit_done(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; } -:273: WARNING:LONG_LINE: line length of 106 exceeds 100 columns #273: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:557: +static inline void i915_gem_object_userptr_submit_fini(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); } -:331: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #331: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:2: * SPDX-License-Identifier: MIT -:335: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #335: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:6: + * + * Based on amdgpu_mn, which bears the following notice: -:336: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #336: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:7: + * Based on amdgpu_mn, which bears the following notice: + * -:483: WARNING:LONG_LINE: line length of 106 exceeds 100 columns #483: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:63: + struct drm_i915_gem_object *obj = container_of(mni, struct drm_i915_gem_object, userptr.notifier); -:1097: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #1097: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:282: + pinned = ret = 0; -:1113: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1113: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:298: + if (mmu_interval_read_retry(&obj->userptr.notifier, + !obj->userptr.page_ref ? notifier_seq : -:1234: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #1234: FILE: drivers/gpu/drm/i915/i915_drv.h:597: + struct mutex notifier_lock; total: 1 errors, 7 warnings, 3 checks, 1169 lines checked 15650ee070ab drm/i915: Flatten obj->mm.lock c30e420a9750 drm/i915: Pin timeline map after first timeline pin, v2. -:13: WARNING:TYPO_SPELLING: 'arithmatic' may be misspelled - perhaps 'arithmetic'? #13: - Fix NULL + XX arithmatic, use casts. (kbuild) total: 0 errors, 1 warnings, 0 checks, 293 lines checked c1ed4a428c27 drm/i915: Populate logical context during first pin. -:176: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #176: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:5523: +virtual_context_pre_pin(struct intel_context *ce, + struct i915_gem_ww_ctx *ww, void **vaddr) total: 0 errors, 0 warnings, 1 checks, 169 lines checked d0fd3756776c drm/i915: Make ring submission compatible with obj->mm.lock removal, v2. 660dea569998 drm/i915: Handle ww locking in init_status_page 55921185af2b drm/i915: Rework clflush to work correctly without obj->mm.lock. 12a10bf2b7d8 drm/i915: Pass ww ctx to intel_pin_to_display_plane a1e5ec4912b7 drm/i915: Add object locking to vm_fault_cpu e23134d2dd6f drm/i915: Move pinning to inside engine_wa_list_verify() -:53: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #53: FILE: drivers/gpu/drm/i915/gt/intel_workarounds.c:2140: + err = i915_vma_pin_ww(vma, &ww, 0, 0, + i915_vma_is_ggtt(vma) ? PIN_GLOBAL : PIN_USER); total: 0 errors, 0 warnings, 1 checks, 109 lines checked d10a12984174 drm/i915: Take reservation lock around i915_vma_pin. b57dc18de910 drm/i915: Make intel_init_workaround_bb more compatible with ww locking. 424250227d5f drm/i915: Make __engine_unpark() compatible with ww locking. 465dcdc78269 drm/i915: Take obj lock around set_domain ioctl 7f3fadccaa43 drm/i915: Defer pin calls in buffer pool until first use by caller. d5f941d41c86 drm/i915: Fix pread/pwrite to work with new locking rules. -:28: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #28: deleted file mode 100644 total: 0 errors, 1 warnings, 0 checks, 401 lines checked f899d71edb0d drm/i915: Fix workarounds selftest, part 1 c865717b2b7e drm/i915: Prepare for obj->mm.lock removal -:131: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author '"Thomas Hellström" <thomas.hellstrom@xxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 96 lines checked b676ba99f5f4 drm/i915: Add igt_spinner_pin() to allow for ww locking around spinner. 2ec4da54d3f8 drm/i915: Add ww locking around vm_access() 1d26619caf00 drm/i915: Increase ww locking for perf. 86ae06998f44 drm/i915: Lock ww in ucode objects correctly f148eedce17a drm/i915: Add ww locking to dma-buf ops. 35779eb08a1d drm/i915: Add missing ww lock in intel_dsb_prepare. 839044c810e5 drm/i915: Fix ww locking in shmem_create_from_object cff75ce36089 drm/i915: Use a single page table lock for each gtt. -:108: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #108: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:85: + return i915_gem_object_lock(vm->scratch[0], ww); + } else { total: 0 errors, 1 warnings, 0 checks, 154 lines checked b296545b74d6 drm/i915/selftests: Prepare huge_pages testcases for obj->mm.lock removal. 8d2d0b5c5a6b drm/i915/selftests: Prepare client blit for obj->mm.lock removal. e73cbf498354 drm/i915/selftests: Prepare coherency tests for obj->mm.lock removal. 1179c9f3b0c3 drm/i915/selftests: Prepare context tests for obj->mm.lock removal. 808639cb86bd drm/i915/selftests: Prepare dma-buf tests for obj->mm.lock removal. 68384a23fb92 drm/i915/selftests: Prepare execbuf tests for obj->mm.lock removal. 907e895aff17 drm/i915/selftests: Prepare mman testcases for obj->mm.lock removal. 479b492085a6 drm/i915/selftests: Prepare object tests for obj->mm.lock removal. 33f4131dcc86 drm/i915/selftests: Prepare object blit tests for obj->mm.lock removal. ada5922697ca drm/i915/selftests: Prepare igt_gem_utils for obj->mm.lock removal 75db7b2bc301 drm/i915/selftests: Prepare context selftest for obj->mm.lock removal 0c18f21d3ec6 drm/i915/selftests: Prepare hangcheck for obj->mm.lock removal 9b3887878326 drm/i915/selftests: Prepare execlists for obj->mm.lock removal -:155: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #155: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5857: + lrc = i915_gem_object_pin_map_unlocked(ce->state->obj, i915_coherent_map_type(engine->i915)); total: 0 errors, 0 warnings, 1 checks, 130 lines checked bb30a39d7d79 drm/i915/selftests: Prepare mocs tests for obj->mm.lock removal 66894ecd6ed2 drm/i915/selftests: Prepare ring submission for obj->mm.lock removal 508424e39e90 drm/i915/selftests: Prepare timeline tests for obj->mm.lock removal 741c1bd4e1bd drm/i915/selftests: Prepare i915_request tests for obj->mm.lock removal d3a4fc3e2ff4 drm/i915/selftests: Prepare memory region tests for obj->mm.lock removal d6c5e39e6e62 drm/i915/selftests: Prepare cs engine tests for obj->mm.lock removal 72f9158f799b drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal a1686a8a2dc6 drm/i915: Finally remove obj->mm.lock. 83b79b693e31 drm/i915: Keep userpointer bindings if seqcount is unchanged _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
