== Series Details == Series: drm/i915/jsl: Split EHL/JSL platform info and PCI ids URL : https://patchwork.freedesktop.org/series/82437/ State : warning == Summary == $ dim checkpatch origin/drm-tip 210bd6977cda drm/i915/jsl: Split EHL/JSL platform info and PCI ids -:214: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pll->info->id == DPLL_ID_EHL_DPLL4' #214: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:155: + if (IS_JSL_EHL(i915) && (pll->info->id == DPLL_ID_EHL_DPLL4)) -:325: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects? #325: FILE: drivers/gpu/drm/i915/i915_drv.h:1420: +#define IS_JSL_EHL(dev_priv) (IS_PLATFORM(dev_priv, INTEL_JASPERLAKE) || \ + IS_PLATFORM(dev_priv, INTEL_ELKHARTLAKE)) -:336: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #336: FILE: drivers/gpu/drm/i915/i915_drv.h:1562: +#define IS_JSL_EHL_REVID(p, since, until) \ + (IS_JSL_EHL(p) && IS_REVID(p, since, until)) -:444: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #444: FILE: include/drm/i915_pciids.h:592: +#define INTEL_JSL_IDS(info) \ + INTEL_VGA_DEVICE(0x4E71, info), \ INTEL_VGA_DEVICE(0x4E61, info), \ INTEL_VGA_DEVICE(0x4E57, info), \ INTEL_VGA_DEVICE(0x4E55, info), \ -:444: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects? #444: FILE: include/drm/i915_pciids.h:592: +#define INTEL_JSL_IDS(info) \ + INTEL_VGA_DEVICE(0x4E71, info), \ INTEL_VGA_DEVICE(0x4E61, info), \ INTEL_VGA_DEVICE(0x4E57, info), \ INTEL_VGA_DEVICE(0x4E55, info), \ total: 1 errors, 0 warnings, 4 checks, 331 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
