On Tue, Feb 19, 2013 at 03:16:39PM +0200, ville.syrjala at linux.intel.com wrote: > From: Ville Syrj?l? <ville.syrjala at linux.intel.com> > > Use the gen3 logic for handling page flip interrupts on gen4. > > Unfortuantely this kills the stall_check since that looks like it can > easily trigger too early. With the current logic the stall check would > kick in on the first vblank after the flip has been submitted to the > ring. If the CS takes longer than that to process the commands in the > ring, the stall check will cause the page flip to be complete too > early. That doesn't sound like a very good idea. Something better > should be deviced if we still need the stall check. For now, mark > i915_pageflip_stall_check() as unused. > > v2: Fix irq enable_mask and add __always_unused (Chris Wilson) > > References: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/1116587 > Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> > Tested-by: Chris Wilson <chris at chris-wilson.co.uk> > Signed-off-by: Ville Syrj?l? <ville.syrjala at linux.intel.com> Both merge to dinq, thanks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
