> -----Original Message----- > From: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> > Sent: Wednesday, September 16, 2020 6:51 AM > To: Srivatsa, Anusha <anusha.srivatsa@xxxxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pll: > Centralize PLL_ENABLE register lookup (rev4) > > On Fri, 11 Sep 2020, Patchwork <patchwork@xxxxxxxxxxxxxxxxxxxxxx> wrote: > > == Series Details == > > > > Series: drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4) > > URL : https://patchwork.freedesktop.org/series/81150/ > > State : warning > > > > == Summary == > > > > $ dim checkpatch origin/drm-tip > > dac234339c17 drm/i915/pll: Centralize PLL_ENABLE register lookup > > -:38: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' > > #38: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:154: > > +{ > > + > > > > -:39: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses > around 'pll->info->id == DPLL_ID_EHL_DPLL4' > > #39: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:155: > > + if (IS_ELKHARTLAKE(i915) && (pll->info->id == DPLL_ID_EHL_DPLL4)) > > > > -:44: CHECK:LINE_SPACING: Please don't use multiple blank lines > > #44: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:160: > > + > > + > > > > -:45: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' > > #45: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:161: > > + > > +} > > We have this in CI so people don't have to bother with mentioning this > stuff. But I do expect people to look at them and fix them. Yes jani. Will definitely keep this in mind. Anusha > BR, > Jani. > > > > > > total: 0 errors, 0 warnings, 4 checks, 66 lines checked > > > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
