Hi Daniel.
On Fri, Sep 04, 2020 at 03:42:44PM +0200, Daniel Vetter wrote:
> On Fri, Apr 24, 2020 at 6:46 PM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> >
> > Hi Daniel.
> >
> > On Wed, Apr 15, 2020 at 09:40:15AM +0200, Daniel Vetter wrote:
> > > Upcasting using a container_of macro is more typesafe, faster and
> > > easier for the compiler to optimize.
> > >
> > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> > > Cc: Alexey Brodkin <abrodkin@xxxxxxxxxxxx>
> >
> > Subject: drm/arc: arcpgu: Stop using drm_device->dev_private
> >
> > And another bikeshedding below.
> > With this considered:
> > Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> >
> > > ---
> > > drivers/gpu/drm/arc/arcpgu.h | 2 ++
> > > drivers/gpu/drm/arc/arcpgu_crtc.c | 4 ++--
> > > drivers/gpu/drm/arc/arcpgu_drv.c | 4 +---
> > > 3 files changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/arc/arcpgu.h b/drivers/gpu/drm/arc/arcpgu.h
> > > index cd9e932f501e..87821c91a00c 100644
> > > --- a/drivers/gpu/drm/arc/arcpgu.h
> > > +++ b/drivers/gpu/drm/arc/arcpgu.h
> > > @@ -17,6 +17,8 @@ struct arcpgu_drm_private {
> > > struct drm_plane *plane;
> > > };
> > >
> > > +#define dev_to_arcpgu(x) container_of(x, struct arcpgu_drm_private, drm)
> > > +
> > Preferred name is to_arcgpu(). There is no device in the name of struct
> > arcpgu_drm_private. And the general consensus it to use to_<driver> for
> > the top-level struct.
>
> [Sorry just realized I never replied on-list for this here]
>
> drm_device very much has a dev_ and there's some other drivders with
> this pattern too. Plus I think it's more consistent with the other
> macros in here. For simple drivers where there's only 1 structure I
> agree though, so if you insist I can follow up with a patch. Fixing
> this in-series is imo too much trouble for the benefit, every single
> patch would need to be redone ...
The naming is my personal choice - others have different opinions.
And since we did not universially agree on dev_to_* versus to_* for the
main driver structure there is no need to adjust.
For me it is just that the main driver structure is more than a device
thingy and I like the short naming. But it seems you, Thomas + more
prefer dev_to_* so maybe I should adjust so we are a little more
aligned.
So it is considered so the patch is obviously:
Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
Sam
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
