== Series Details == Series: drm/i915/pll: Centralize PLL_ENABLE register lookup (rev2) URL : https://patchwork.freedesktop.org/series/81150/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2b838e80247e drm/i915/pll: Centralize PLL_ENABLE register lookup -:30: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #30: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:152: +i915_reg_t intel_combo_pll_enable_reg(struct drm_i915_private *dev_priv, + struct intel_shared_dpll *pll) -:32: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #32: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:154: +{ + -:33: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24) #33: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:155: + if (IS_ELKHARTLAKE(dev_priv) && (pll->info->id == DPLL_ID_EHL_DPLL4)) + return MG_PLL_ENABLE(0); -:33: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pll->info->id == DPLL_ID_EHL_DPLL4' #33: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:155: + if (IS_ELKHARTLAKE(dev_priv) && (pll->info->id == DPLL_ID_EHL_DPLL4)) -:38: CHECK:LINE_SPACING: Please don't use multiple blank lines #38: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:160: + + -:39: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #39: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:161: + +} total: 0 errors, 1 warnings, 5 checks, 55 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
