== Series Details == Series: drm/dp, i915, nouveau: Cleanup nouveau HPD and add DP features from i915 (rev7) URL : https://patchwork.freedesktop.org/series/80542/ State : warning == Summary == $ dim checkpatch origin/drm-tip b76b4b6f3675 drm/nouveau/kms: Fix some indenting in nouveau_dp_detect() -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 21 lines checked 376f1358fe13 drm/nouveau/kms/nv50-: Remove open-coded drm_dp_read_desc() -:102: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct nouveau_connector *' should also have an identifier name #102: FILE: drivers/gpu/drm/nouveau/nouveau_encoder.h:109: +int nouveau_dp_detect(struct nouveau_connector *, struct nouveau_encoder *); -:102: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct nouveau_encoder *' should also have an identifier name #102: FILE: drivers/gpu/drm/nouveau/nouveau_encoder.h:109: +int nouveau_dp_detect(struct nouveau_connector *, struct nouveau_encoder *); total: 0 errors, 2 warnings, 0 checks, 74 lines checked bb5629743bd6 drm/nouveau/kms/nv50-: Just use drm_dp_dpcd_read() in nouveau_dp.c 5a0c0ceff3b9 drm/nouveau/kms/nv50-: Use macros for DP registers in nouveau_dp.c ed53a7f096cc drm/nouveau/kms: Don't clear DP_MST_CTRL DPCD in nv50_mstm_new() -:7: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit fa3cdf8d0b09 ("drm/nouveau: Reset MST branching unit before enabling")' #7: Since fa3cdf8d0b09 ("drm/nouveau: Reset MST branching unit before total: 1 errors, 0 warnings, 0 checks, 17 lines checked 2e212bc94c2b drm/nouveau/kms: Search for encoders' connectors properly d5c0b632ff50 drm/nouveau/kms/nv50-: Use drm_dp_dpcd_(readb|writeb)() in nv50_sor_disable() a494bdb7a99a drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD handling -:53: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #53: * Enabling bits in MSTM_CTRL before calling drm_dp_mst_topology_mgr_set_mst(). -:465: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_device *' should also have an identifier name #465: FILE: drivers/gpu/drm/nouveau/nouveau_display.h:21: + void (*fini)(struct drm_device *, bool suspend, bool runtime); total: 0 errors, 2 warnings, 0 checks, 574 lines checked 93c32b56a998 drm/i915/dp: Extract drm_dp_read_mst_cap() ab23bfd0015b drm/nouveau/kms: Use new drm_dp_read_mst_cap() helper for checking MST caps -:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 29 lines checked d218727b4477 drm/nouveau/kms: Move drm_dp_cec_unset_edid() into nouveau_connector_detect() 375b0f4cdd81 drm/nouveau/kms: Only use hpd_work for reprobing in HPD paths -:279: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #279: FILE: drivers/gpu/drm/nouveau/nouveau_drv.h:201: + struct mutex hpd_lock; total: 0 errors, 0 warnings, 1 checks, 219 lines checked 0134505297a1 drm/i915/dp: Extract drm_dp_read_downstream_info() -:38: WARNING:BAD_SIGN_OFF: Duplicate signature #38: Signed-off-by: Lyude Paul <lyude@xxxxxxxxxx> total: 0 errors, 1 warnings, 0 checks, 109 lines checked c4728875a1e1 drm/nouveau/kms/nv50-: Use downstream DP clock limits for mode validation -:63: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #63: FILE: drivers/gpu/drm/nouveau/nouveau_dp.c:194: + unsigned max_clock, ds_clock, clock; total: 0 errors, 1 warnings, 0 checks, 57 lines checked 21a1acc8b05d drm/i915/dp: Extract drm_dp_read_sink_count_cap() b10ed3135378 drm/i915/dp: Extract drm_dp_read_sink_count() -:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #12: * Add back comment and move back sink_count assignment in intel_dp_get_dpcd() total: 0 errors, 1 warnings, 0 checks, 74 lines checked 9de8d3818bd8 drm/nouveau/kms/nv50-: Add support for DP_SINK_COUNT -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #11: plugged into it currently results in a bogus EDID retrieval error in the kernel log. total: 0 errors, 1 warnings, 0 checks, 107 lines checked b2ef4135a827 drm/nouveau/kms: Don't change EDID when it hasn't actually changed 6da06b467e41 drm/i915/dp: Extract drm_dp_read_dpcd_caps() 02383c82b60a drm/nouveau/kms: Start using drm_dp_read_dpcd_caps() _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
