On Wed, Aug 19, 2020 at 11:51:46AM -0700, José Roberto de Souza wrote: > Update with latest tunning in the table. > > BSpec: 21257 > Signed-off-by: José Roberto de Souza <jose.souza@xxxxxxxxx> It looks like we now have separate tables for EHL and JSL; we probably need to handle them with separate tables now. > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > index 0fa4075036e6..6271034455a8 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -572,14 +572,14 @@ static const struct cnl_ddi_buf_trans ehl_combo_phy_ddi_translations_dp[] = { > /* NT mV Trans mV db */ > { 0xA, 0x33, 0x3F, 0x00, 0x00 }, /* 350 350 0.0 */ > { 0xA, 0x47, 0x36, 0x00, 0x09 }, /* 350 500 3.1 */ > - { 0xC, 0x64, 0x30, 0x00, 0x0F }, /* 350 700 6.0 */ > - { 0x6, 0x7F, 0x2C, 0x00, 0x13 }, /* 350 900 8.2 */ > + { 0xC, 0x64, 0x34, 0x00, 0x0B }, /* 350 700 6.0 */ > + { 0x6, 0x7F, 0x30, 0x00, 0x0F }, /* 350 900 8.2 */ > { 0xA, 0x46, 0x3F, 0x00, 0x00 }, /* 500 500 0.0 */ > - { 0xC, 0x64, 0x36, 0x00, 0x09 }, /* 500 700 2.9 */ > - { 0x6, 0x7F, 0x30, 0x00, 0x0F }, /* 500 900 5.1 */ > + { 0xC, 0x64, 0x38, 0x00, 0x07 }, /* 500 700 2.9 */ > + { 0x6, 0x7F, 0x32, 0x00, 0x0D }, /* 500 900 5.1 */ > { 0xC, 0x61, 0x3F, 0x00, 0x00 }, /* 650 700 0.6 */ > - { 0x6, 0x7F, 0x37, 0x00, 0x08 }, /* 600 900 3.5 */ > - { 0x6, 0x7F, 0x3F, 0x00, 0x00 }, /* 900 900 0.0 */ > + { 0x6, 0x7F, 0x37, 0x00, 0x07 }, /* 600 900 3.5 */ > + { 0x6, 0x7F, 0x38, 0x00, 0x00 }, /* 900 900 0.0 */ These last two entries might have already changed again in the bspec since you wrote this. For EHL I see: 0x6, 0x7f, 0x38, 0x00, 0x07 0x6, 0x7f, 0x3f, 0x00, 0x00 (i.e., the third column is slightly different). And the JSL table has other deltas as well since it just got added. Matt > }; > > struct icl_mg_phy_ddi_buf_trans { > -- > 2.28.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx