On 2020-08-14 at 08:19:50 +0530, Nischal Varide wrote:
> ---
> drivers/gpu/drm/i915/display/intel_combo_phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> index eccaa79cb4a9..6e721b8ed611 100644
> --- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> @@ -258,7 +258,7 @@ static bool phy_is_master(struct drm_i915_private *dev_priv, enum phy phy)
> static bool icl_combo_phy_verify_state(struct drm_i915_private *dev_priv,
> enum phy phy)
> {
> - bool ret;
> + bool ret = 1;
IMHO in this function in each code flow ret is assigned with some value,
so i have not noticed any case ret could return any garbag value here.
It seems a false alarm to me.
Thanks,
Anshuman Gupta.
> u32 expected_val = 0;
>
> if (!icl_combo_phy_enabled(dev_priv, phy))
> --
> 2.26.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
