On Fri, Jun 12, 2020 at 1:47 PM Matt Roper <matthew.d.roper@xxxxxxxxx> wrote:
>
> A recent bspec update removed the LPDDR4 single channel entry from the
> buddy register table, but added a new four-channel entry.
>
> Workaround 1409767108 hasn't been updated with any guidance for four
> channel configurations, so we leave that alternate table unchanged for
> now.
>
> Bspec 49218
> Fixes: 3fa01d642fa7 ("drm/i915/tgl: Program BW_BUDDY registers during display init")
> Signed-off-by: Matt Roper <matthew.d.roper@xxxxxxxxx>
Matches spec.
Reviewed-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
Lucas De Marchi
> ---
> drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index 24a2aa1fdc9c..a592a7dd71a3 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -5240,10 +5240,10 @@ struct buddy_page_mask {
> };
>
> static const struct buddy_page_mask tgl_buddy_page_masks[] = {
> - { .num_channels = 1, .type = INTEL_DRAM_LPDDR4, .page_mask = 0xE },
> { .num_channels = 1, .type = INTEL_DRAM_DDR4, .page_mask = 0xF },
> { .num_channels = 2, .type = INTEL_DRAM_LPDDR4, .page_mask = 0x1C },
> { .num_channels = 2, .type = INTEL_DRAM_DDR4, .page_mask = 0x1F },
> + { .num_channels = 4, .type = INTEL_DRAM_LPDDR4, .page_mask = 0x38 },
> {}
> };
>
> --
> 2.24.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
