Quoting Umesh Nerlige Ramappa (2020-07-24 20:35:11) > I agree, but strangely, with mmap sequence below, I don't see > i915_perf_release() called at all. So destroy() is not called. > > perf_fd = i915_perf_open_ioctl() > mmap(..., perf_fd...) > close(perf_fd) > delay for a few seconds. > > If I call munmap() after the close(), I see i915_perf_release() -> > destroy() -> unmap_mapping_range() Hmm, vma->vm_file is pointing to the perf-fd. Ah, that's a big difference to what I'm used to. So all the references are handled for you by the correct vma->vm_file, and you don't need the vm_open/vm_close, the kref or the closed. Sorry. -Chris --------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
