✗ Fi.CI.CHECKPATCH: warning for Asynchronous flip implementation for i915 (rev4)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: Asynchronous flip implementation for i915 (rev4)
URL   : https://patchwork.freedesktop.org/series/74386/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b48aa69c41de drm/i915: Add enable/disable flip done and flip done handler
-:28: WARNING:TYPO_SPELLING: 'begining' may be misspelled - perhaps 'beginning'?
#28: 
    -Make the pending vblank event NULL in the begining of

total: 0 errors, 1 warnings, 0 checks, 197 lines checked
64fa1ff84ea3 drm/i915: Add support for async flips in I915
2fe12b0307ea drm/i915: Add checks specific to async flips
-:48: WARNING:TYPO_SPELLING: 'Requried' may be misspelled - perhaps 'Required'?
#48: FILE: drivers/gpu/drm/i915/display/intel_display.c:14839:
+			DRM_DEBUG_KMS("Modeset Requried. Async flip not supported\n");

-:72: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'old_plane_state->color_plane[0].x !=
 		     new_plane_state->color_plane[0].x'
#72: FILE: drivers/gpu/drm/i915/display/intel_display.c:14863:
+		if ((old_plane_state->color_plane[0].x !=
+		     new_plane_state->color_plane[0].x) ||
+		    (old_plane_state->color_plane[0].y !=
+		     new_plane_state->color_plane[0].y)) {

-:72: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'old_plane_state->color_plane[0].y !=
 		     new_plane_state->color_plane[0].y'
#72: FILE: drivers/gpu/drm/i915/display/intel_display.c:14863:
+		if ((old_plane_state->color_plane[0].x !=
+		     new_plane_state->color_plane[0].x) ||
+		    (old_plane_state->color_plane[0].y !=
+		     new_plane_state->color_plane[0].y)) {

-:102: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#102: FILE: drivers/gpu/drm/i915/display/intel_display.c:14893:
+		if (old_plane_state->uapi.pixel_blend_mode != new_plane_state->uapi.pixel_blend_mode) {

total: 0 errors, 2 warnings, 2 checks, 115 lines checked
c68f7e3b6d25 drm/i915: Do not call drm_crtc_arm_vblank_event in async flips
2f73114a8669 drm/i915: Enable async flips in i915

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux