Re: [PATCH v2 1/2] drm/i915: Reboot CI if we get wedged during driver init

[Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>]

Quoting Michał Winiarski (2020-07-06 11:49:52)
> From: Michał Winiarski <michal.winiarski@xxxxxxxxx>
> 
> Getting wedged device on driver init is pretty much unrecoverable.
> Since we're running various scenarios that may potentially hit this in
> CI (module reload / selftests / hotunplug), and if it happens, it means
> that we can't trust any subsequent CI results, we should just apply the
> taint to let the CI know that it should reboot (CI checks taint between
> test runs).
> 
> v2: Comment that WEDGED_ON_INIT is non-recoverable, distinguish
>     WEDGED_ON_INIT from WEDGED_ON_FINI (Chris)
> 
> Signed-off-by: Michał Winiarski <michal.winiarski@xxxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>
> Cc: Petri Latvala <petri.latvala@xxxxxxxxx>

+1 for has_unrecoverable_error()
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

> -static inline bool intel_gt_has_init_error(const struct intel_gt *gt)
> +static inline bool intel_gt_is_wedged(const struct intel_gt *gt)
>  {
> -       return test_bit(I915_WEDGED_ON_INIT, &gt->reset.flags);
> +       GEM_BUG_ON(intel_gt_has_unrecoverable_error(gt) ?
> +                  !test_bit(I915_WEDGED, &gt->reset.flags) : false);

GEM_BUG_ON(intel_gt_has_unrecoverable_error(gt) &&
	   !test_bit(I915_WEDGED, &gt->reset.flags));

Perhaps a bit more conventional way of saying the same :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx