On Wed, 01 Jul 2020, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote:
> On Wed, 24 Jun 2020, Lucas De Marchi <lucas.demarchi@xxxxxxxxx> wrote:
>>
>> +struct intel_ddi_port_info {
>
> Just thinking out loud, should we have a "struct port" or "struct
> intel_port" instead. Maybe, maybe not. *shrug*
After reading the whole series, I might lean even more towards
introducing a struct intel_port.
Not insisting you'd have to do that as part of this series, but
something to consider. How would things look like?
BR,
Jani.
>
> Anyway the patch is
>
> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
>> + const char *name;
>> + enum port port;
>> +};
>> +
>> static inline enum dpio_channel
>> vlv_dport_to_channel(struct intel_digital_port *dport)
>> {
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
