Re: [PATCH 3/3] drm/edid: Clean up some curly braces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2020-05-27 at 16:03 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> 
> Drop some pointless curly braces, and add some across the
> else when the if has them too.

Reviewed-by: José Roberto de Souza <jose.souza@xxxxxxxxx>

> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/drm_edid.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index dcb23563d29d..8a951e2bfb41 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -5836,22 +5836,21 @@ static void drm_parse_tiled_block(struct drm_connector *connector,
>  	DRM_DEBUG_KMS("vend %c%c%c\n", tile->topology_id[0], tile->topology_id[1], tile->topology_id[2]);
>  
>  	tg = drm_mode_get_tile_group(connector->dev, tile->topology_id);
> -	if (!tg) {
> +	if (!tg)
>  		tg = drm_mode_create_tile_group(connector->dev, tile->topology_id);
> -	}
>  	if (!tg)
>  		return;
>  
>  	if (connector->tile_group != tg) {
>  		/* if we haven't got a pointer,
>  		   take the reference, drop ref to old tile group */
> -		if (connector->tile_group) {
> +		if (connector->tile_group)
>  			drm_mode_put_tile_group(connector->dev, connector->tile_group);
> -		}
>  		connector->tile_group = tg;
> -	} else
> +	} else {
>  		/* if same tile group, then release the ref we just took. */
>  		drm_mode_put_tile_group(connector->dev, tg);
> +	}
>  }
>  
>  static void drm_displayid_parse_tiled(struct drm_connector *connector,
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux