✗ Fi.CI.CHECKPATCH: warning for Send a hotplug when edid changes (rev9)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: Send a hotplug when edid changes (rev9)
URL   : https://patchwork.freedesktop.org/series/62816/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
8c236463353b drm: Add helper to compare edids.
-:34: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "edid1"
#34: FILE: drivers/gpu/drm/drm_edid.c:1628:
+	bool edid1_present = edid1 != NULL;

-:35: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "edid2"
#35: FILE: drivers/gpu/drm/drm_edid.c:1629:
+	bool edid2_present = edid2 != NULL;

-:41: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#41: FILE: drivers/gpu/drm/drm_edid.c:1635:
+	if (edid1) {
+

-:56: CHECK:LINE_SPACING: Please don't use multiple blank lines
#56: FILE: drivers/gpu/drm/drm_edid.c:1650:
+
+

total: 0 errors, 0 warnings, 4 checks, 54 lines checked
67927d889ffe drm: Introduce epoch counter to drm_connector
-:58: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#58: FILE: drivers/gpu/drm/drm_connector.c:2012:
+				DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Edid was changed.\n",
+				    connector->base.id, connector->name);

-:62: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#62: FILE: drivers/gpu/drm/drm_connector.c:2016:
+				DRM_DEBUG_KMS("Updating change counter to %llu\n",
+				    connector->epoch_counter);

-:131: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t'
#131: FILE: drivers/gpu/drm/drm_probe_helper.c:790:
+	uint64_t old_epoch_counter;

-:162: WARNING:BRACES: braces {} are not necessary for single statement blocks
#162: FILE: drivers/gpu/drm/drm_probe_helper.c:826:
+		if (old_epoch_counter != connector->epoch_counter) {
 			changed = true;
+		}

-:186: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t'
#186: FILE: include/drm/drm_connector.h:1333:
+	uint64_t epoch_counter;

total: 0 errors, 1 warnings, 4 checks, 136 lines checked
04bfaff00368 drm/i915: Send hotplug event if edid had changed

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux