Hi Daniel, On Fri, 12 Jun 2020 at 17:01, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote: > > The atomic helpers try really hard to not lose track of things, > duplicating enabled tracking in the driver is at best confusing. > Double-enabling or disabling is a bug in atomic helpers. > > In the fb_dirty function we can just assume that the fb always exists, > simple display pipe helpers guarantee that the crtc is only enabled > together with the output, so we always have a primary plane around. > > Now in the update function we need to be a notch more careful, since > that can also get called when the crtc is off. And we don't want to > upload frames when that's the case, so filter that out too. > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> > Cc: Maxime Ripard <mripard@xxxxxxxxxx> > Cc: Thomas Zimmermann <tzimmermann@xxxxxxx> > Cc: David Airlie <airlied@xxxxxxxx> > Cc: Daniel Vetter <daniel@xxxxxxxx> > Cc: David Lechner <david@xxxxxxxxxxxxxx> > --- > drivers/gpu/drm/drm_mipi_dbi.c | 16 ++++++---------- > drivers/gpu/drm/tiny/ili9225.c | 12 +++--------- > drivers/gpu/drm/tiny/st7586.c | 11 +++-------- > include/drm/drm_mipi_dbi.h | 5 ----- > 4 files changed, 12 insertions(+), 32 deletions(-) > > diff --git a/drivers/gpu/drm/drm_mipi_dbi.c b/drivers/gpu/drm/drm_mipi_dbi.c > index fd8d672972a9..79532b9a324a 100644 > --- a/drivers/gpu/drm/drm_mipi_dbi.c > +++ b/drivers/gpu/drm/drm_mipi_dbi.c > @@ -268,7 +268,7 @@ static void mipi_dbi_fb_dirty(struct drm_framebuffer *fb, struct drm_rect *rect) > bool full; > void *tr; > > - if (!dbidev->enabled) > + if (WARN_ON(!fb)) > return; > AFAICT no other driver has such WARN_ON. Let's drop that - it is pretty confusing and misleading as-is. With that, patches 7/8 and 8/8 are: Reviewed-by: Emil Velikov <emil.l.velikov@xxxxxxxxx> -Emil _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
