Re: pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Mon, Jun 08, 2020 at 04:35:00PM +0200, Daniel Vetter wrote:
> On Sat, Jun 06, 2020 at 10:25:45PM +0200, Hans de Goede wrote:
> > Hi All,
> > 
> > This patch series converts the i915 driver's cpde for controlling the
> > panel's backlight with an external PWM controller to use the atomic PWM API.
> > 
> > Initially the plan was for this series to consist of 2 parts:
> > 1. convert the pwm-crc driver to support the atomic PWM API and
> > 2. convert the i915 driver's PWM code to use the atomic PWM API.
> > 
> > But during testing I've found a number of bugs in the pwm-lpss and I
> > found that the acpi_lpss code needs some special handling because of
> > some ugliness found in most Cherry Trail DSDTs.
> > 
> > So now this series has grown somewhat large and consists of 4 parts:
> > 
> > 1. acpi_lpss fixes workarounds for Cherry Trail DSTD nastiness
> > 2. various fixes to the pwm-lpss driver
> > 3. convert the pwm-crc driver to support the atomic PWM API and
> > 4. convert the i915 driver's PWM code to use the atomic PWM API
> > 
> > So we need to discuss how to merge this (once it passes review).
> > Although the inter-dependencies are only runtime I still think we should
> > make sure that 1-3 are in the drm-intel-next-queued (dinq) tree before
> > merging the i915 changes. Both to make sure that the intel-gfx CI system
> > does not become unhappy and for bisecting reasons.
> 
> Simplest is if acpi acks the acpi patches for merging through
> drm-intel.git. Second simplest is topic branch (drm-intel maintainers can
> do that) with the entire pile, which then acpi and drm-intel can both pull
> in.
> 
> Up to the two maintainer teams to figure this one out.

I'm unclear about the dependencies, but the changes to drivers/pwm need
an ack (or processing) by the PWM team.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux