== Series Details == Series: dma-fence lockdep annotations, round 2 (rev3) URL : https://patchwork.freedesktop.org/series/77986/ State : warning == Summary == $ dim checkpatch origin/drm-tip b91d6e9b2219 mm: Track mmu notifiers in fs_reclaim_acquire/release -:12: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 23b68395c7c7 ("mm/mmu_notifiers: add a lockdep map for invalidate_range_start/end")' #12: recursions we do have lockdep annotations since 23b68395c7c7 -:41: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 66204f1d2d1b ("mm/mmu_notifiers: prime lockdep")' #41: With this we can also remove the lockdep priming added in 66204f1d2d1b -:124: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #124: FILE: mm/page_alloc.c:4167: + + } -:138: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 2 errors, 1 warnings, 1 checks, 67 lines checked 464bebc66202 dma-buf: minor doc touch-ups -:33: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 14 lines checked 4a356e005b80 dma-fence: basic lockdep annotations -:23: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit e91498589746 ("locking/lockdep/selftests: Add mixed read-write ABBA tests")' #23: commit e91498589746065e3ae95d9a00b068e525eec34f -:97: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit e966eaeeb623 ("locking/lockdep: Remove the cross-release locking checks")' #97: commit e966eaeeb623f09975ef362c2866fae6f86844f9 -:103: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #103: This code (CONFIG_LOCKDEP_CROSSRELEASE=y and CONFIG_LOCKDEP_COMPLETIONS=y), -:314: ERROR:IN_ATOMIC: do not use in_atomic in drivers #314: FILE: drivers/dma-buf/dma-fence.c:228: + if (in_atomic()) -:352: CHECK:LINE_SPACING: Please don't use multiple blank lines #352: FILE: drivers/dma-buf/dma-fence.c:266: + + -:401: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #401: FILE: include/linux/dma-fence.h:368: +} +static inline void dma_fence_end_signalling(bool cookie) {} -:407: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 3 errors, 2 warnings, 2 checks, 231 lines checked e85757129eef dma-fence: prime lockdep annotations -:31: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 23b68395c7c7 ("mm/mmu_notifiers: add a lockdep map for invalidate_range_start/end")' #31: commit 23b68395c7c78a764e8963fc15a7cfd318bf187f -:169: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 1 errors, 1 warnings, 0 checks, 82 lines checked abea167ccc2c drm/vkms: Annotate vblank timer -:59: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 25 lines checked 74cf66d0c736 drm/vblank: Annotate with dma-fence signalling section -:71: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 38 lines checked 49852bebf34d drm/atomic-helper: Add dma-fence annotations -:119: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 76 lines checked 812e8d183ea1 drm/amdgpu: add dma-fence annotations to atomic commit path -:52: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 24 lines checked e86ec566effc drm/scheduler: use dma-fence annotations in main thread -:53: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 21 lines checked d05e15f8ad27 drm/amdgpu: use dma-fence annotations in cs_submit() -:65: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 29 lines checked 805637835bf6 drm/amdgpu: s/GFP_KERNEL/GFP_ATOMIC in scheduler code -:82: WARNING:ALLOC_ARRAY_ARGS: kmalloc_array uses number as first arg, sizeof is generally wrong #82: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:211: + fences = kmalloc_array(sizeof(void *), id_mgr->num_ids, GFP_ATOMIC); -:98: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 24 lines checked 18403b85aff4 drm/amdgpu: DC also loves to allocate stuff where it shouldn't -:70: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #70: FILE: drivers/gpu/drm/amd/display/dc/core/dc.c:1436: + * atomic_commit_tail. */ -:76: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 27 lines checked 2dbc37297b21 drm/amdgpu/dc: Stop dma_resv_lock inversion in commit_tail -:39: WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #39: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:6914: +#if 0 -:55: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 23 lines checked d1361c491f79 drm/scheduler: use dma-fence annotations in tdr work -:28: WARNING:TYPO_SPELLING: 'seperate' may be misspelled - perhaps 'separate'? #28: Hence split out as a seperate patch. -:114: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 20 lines checked 718c082d14cb drm/amdgpu: use dma-fence annotations for gpu reset code f08fc8bb8383 Revert "drm/amdgpu: add fbdev suspend/resume on gpu reset" -:145: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 16 lines checked c40ab1c8276b drm/amdgpu: gpu recovery does full modesets -:186: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 14 lines checked c8130cec52d5 drm/i915: Annotate dma_fence_work -:53: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 15 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
