On Sun, Jan 27, 2013 at 11:21 PM, Rafael J. Wysocki <rjw at sisk.pl> wrote: >> Given that this essentially requires users to manually set this module >> option to make stuff work I don't like this. >> >> I see a few possible options: >> - plug the races between all the different parts - I've never really >> understood why acpi sends us events before the resume code has >> completed ... > > This particular one may be a result of patch [2/3] in the series, > actually, because that patch makes SCI work over the whole cycle. > >> If that's indeed intentional, we could delay the >> handling a bit until at least the i915 resume code completed. > > I would do that for now at least if possible. It shouldn't hurt anyway. Since I lack a bit clue about how the pm stuff works exactly: Is there a ready-made helper for that kind of synchronization, where a notifier callback can be called from a different device's resume callbacks, which is someplace completely unrelated in the device-tree? Or any anti-patterns to avoid? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
