On Tue, May 12, 2020 at 08:41:45PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Use max() instead of hand rolling it. > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Reviewed-by: Manasi Navare <manasi.d.navare@xxxxxxxxx> Manasi > --- > drivers/gpu/drm/i915/display/intel_dp_link_training.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > index aa7af531bcb8..2493142a70e9 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > @@ -59,13 +59,8 @@ void intel_dp_get_adjust_train(struct intel_dp *intel_dp, > u8 preemph_max; > > for (lane = 0; lane < intel_dp->lane_count; lane++) { > - u8 this_v = drm_dp_get_adjust_request_voltage(link_status, lane); > - u8 this_p = drm_dp_get_adjust_request_pre_emphasis(link_status, lane); > - > - if (this_v > v) > - v = this_v; > - if (this_p > p) > - p = this_p; > + v = max(v, drm_dp_get_adjust_request_voltage(link_status, lane)); > + p = max(p, drm_dp_get_adjust_request_pre_emphasis(link_status, lane)); > } > > preemph_max = intel_dp->preemph_max(intel_dp); > -- > 2.26.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx