From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Final pieces for plumbing the crtc state all the way down to the guts of the link trainign code. Allows us to eliminate a bunch of adhoc state from intel_dp, and nukes some of the remaining crtc->config usages. I'm also fixing the DP spec violations around the vswing/pre-emphasis selection. Someone pointed that issue out a while ago but there was never any followup to that discussion AFAICS. I had to neuter the phy test code since it has snuck in some duplicated low level modeset code straight into the short hpd handler in intel_dp.c, which is definitely not the way we want to do things. So that stuff needs a real redesign at some point. Ville Syrjälä (9): drm/i915: Fix cpt/ppt max pre-emphasis drm/i915: Fix ibx max vswing/preemph drm/i915: Fix ivb cpu edp vswing drm/i915: Add {preemph,voltage}_max() vfuncs drm/i915: Reverse preemph vs. voltage swing preference drm/i915: Fix DP_TRAIN_MAX_{PRE_EMPHASIS,SWING}_REACHED handling drm/i915: Replace some hand rolled max()s drm/i915: Plumb crtc_state to link training drm/i915: Eliminate intel_dp.regs.dp_tp_{ctl,status} drivers/gpu/drm/i915/display/intel_ddi.c | 454 +++++++++--------- drivers/gpu/drm/i915/display/intel_ddi.h | 14 +- .../drm/i915/display/intel_display_types.h | 26 +- drivers/gpu/drm/i915/display/intel_dp.c | 216 +++++---- drivers/gpu/drm/i915/display/intel_dp.h | 15 +- .../drm/i915/display/intel_dp_link_training.c | 136 +++--- .../drm/i915/display/intel_dp_link_training.h | 7 +- drivers/gpu/drm/i915/display/intel_dp_mst.c | 10 +- drivers/gpu/drm/i915/display/intel_dpio_phy.c | 23 +- drivers/gpu/drm/i915/display/intel_dpio_phy.h | 2 + drivers/gpu/drm/i915/display/intel_hdmi.c | 7 +- 11 files changed, 467 insertions(+), 443 deletions(-) -- 2.24.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx