== Series Details == Series: Introduce Rocket Lake (rev4) URL : https://patchwork.freedesktop.org/series/76826/ State : warning == Summary == $ dim checkpatch origin/drm-tip e6bef4e2c937 drm/i915/rkl: Add RKL platform info and PCI ids -:35: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #35: FILE: drivers/gpu/drm/i915/i915_drv.h:1522: +#define IS_RKL_REVID(p, since, until) \ + (IS_ROCKETLAKE(p) && IS_REVID(p, since, until)) -:102: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #102: FILE: include/drm/i915_pciids.h:609: +#define INTEL_RKL_IDS(info) \ + INTEL_VGA_DEVICE(0x4C80, info), \ + INTEL_VGA_DEVICE(0x4C8A, info), \ + INTEL_VGA_DEVICE(0x4C8B, info), \ + INTEL_VGA_DEVICE(0x4C8C, info), \ + INTEL_VGA_DEVICE(0x4C90, info), \ + INTEL_VGA_DEVICE(0x4C9A, info) -:102: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects? #102: FILE: include/drm/i915_pciids.h:609: +#define INTEL_RKL_IDS(info) \ + INTEL_VGA_DEVICE(0x4C80, info), \ + INTEL_VGA_DEVICE(0x4C8A, info), \ + INTEL_VGA_DEVICE(0x4C8B, info), \ + INTEL_VGA_DEVICE(0x4C8C, info), \ + INTEL_VGA_DEVICE(0x4C90, info), \ + INTEL_VGA_DEVICE(0x4C9A, info) total: 1 errors, 0 warnings, 2 checks, 69 lines checked 803b4f04888a x86/gpu: add RKL stolen memory support 630f1d4d8718 drm/i915/rkl: Re-use TGL GuC/HuC firmware 90f79585717f drm/i915/rkl: Load DMC firmware for Rocket Lake 1c85ab4847be drm/i915/rkl: Add PCH support dc4048963014 drm/i915/rkl: Update memory bandwidth parameters a445dde7ad9f drm/i915/rkl: Limit number of universal planes to 5 f02fc9990788 drm/i915/rkl: Add power well support fda2d4b25173 drm/i915/rkl: Program BW_BUDDY0 registers instead of BW_BUDDY1/2 -:36: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #36: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:5261: + min_buddy = max_buddy = 0; total: 0 errors, 0 warnings, 1 checks, 84 lines checked 7846d1a805b9 drm/i915/rkl: RKL only uses PHY_MISC for PHY's A and B 02aa4c0c4f8f drm/i915/rkl: Handle new DPCLKA_CFGCR0 layout 1c3381316fe1 drm/i915/rkl: Check proper SDEISR bits for TC1 and TC2 outputs a8c3d67dc688 drm/i915/rkl: Setup ports/phys 196dbf07dad1 drm/i915/rkl: provide port/phy mapping for vbt -:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #17: [drm:intel_dp_init_connector [i915]] Adding DP connector on [ENCODER:275:DDI A] total: 0 errors, 1 warnings, 0 checks, 104 lines checked 3c2d8a199e89 drm/i915/rkl: Add DDC pin mapping b8b1dbd88b20 drm/i915/rkl: Don't try to access transcoder D 6906840e8b24 drm/i915/rkl: Don't try to read out DSI transcoders 5018930e1944 drm/i915/rkl: Handle comp master/slave relationships for PHYs 69bfbb9c7a02 drm/i915/rkl: Add DPLL4 support 8b97223a1c60 drm/i915/rkl: Handle HTI -:92: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #92: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:274: +{ + -:154: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #154: FILE: drivers/gpu/drm/i915/i915_reg.h:2903: +#define HDPORT_PHY_USED_DP(phy) REG_BIT(2*phy + 2) ^ -:154: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'phy' may be better as '(phy)' to avoid precedence issues #154: FILE: drivers/gpu/drm/i915/i915_reg.h:2903: +#define HDPORT_PHY_USED_DP(phy) REG_BIT(2*phy + 2) -:155: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #155: FILE: drivers/gpu/drm/i915/i915_reg.h:2904: +#define HDPORT_PHY_USED_HDMI(phy) REG_BIT(2*phy + 1) ^ -:155: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'phy' may be better as '(phy)' to avoid precedence issues #155: FILE: drivers/gpu/drm/i915/i915_reg.h:2904: +#define HDPORT_PHY_USED_HDMI(phy) REG_BIT(2*phy + 1) total: 0 errors, 0 warnings, 5 checks, 116 lines checked 0126c509f30f drm/i915/rkl: Disable PSR2 9b58f54fa37e drm/i915/rkl: Add initial workarounds _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx