On Sun, May 03, 2020 at 07:00:34PM +0100, Chris Wilson wrote: > If the FBC is still writing into stolen, it will overwrite any future > users of that stolen region. Check before release. > > References: https://gitlab.freedesktop.org/drm/intel/-/issues/1635 > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_fbc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c > index c6afa10e814c..37244ed92ae4 100644 > --- a/drivers/gpu/drm/i915/display/intel_fbc.c > +++ b/drivers/gpu/drm/i915/display/intel_fbc.c > @@ -540,6 +540,9 @@ static void __intel_fbc_cleanup_cfb(struct drm_i915_private *dev_priv) > { > struct intel_fbc *fbc = &dev_priv->fbc; > > + if (WARN_ON(intel_fbc_hw_is_active(dev_priv))) > + return; > + Can't immediately see how that would hapoen, but no harm in checking. Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > if (!drm_mm_node_allocated(&fbc->compressed_fb)) > return; > > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
