Quoting Matt Roper (2020-05-02 05:57:42) > @@ -961,6 +955,9 @@ tgl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal) > static void > gt_init_workarounds(struct drm_i915_private *i915, struct i915_wa_list *wal) > { > + if (INTEL_GEN(i915) >= 10) > + wa_init_mcr(i915, wal); The interaction between the MCR steering and the replay of w/a is not obvious, it could do with a comment to avoid future mistakes. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx