Quoting Chris Wilson (2020-05-01 13:38:03) > Quoting Tvrtko Ursulin (2020-05-01 13:33:14) > > > > On 01/05/2020 11:18, Chris Wilson wrote: > > > + > > > + err = 0; > > > + if (rq->engine->emit_init_breadcrumb) > > > + err = rq->engine->emit_init_breadcrumb(rq); > > > + if (!err) > > > + err = rq->engine->emit_bb_start(rq, > > > + rq->batch->node.start, > > > + PAGE_SIZE, > > > + reloc_bb_flags(cache)); > > > + if (err) > > > + i915_request_set_error_once(rq, err); > > > > Will this error propagate and fail the execbuf? > > It fails the execution, but not the execbuf... I was thinking it was too > late for the execbuf, but return err at the end propagates nicely! This is much easier in #2, so I'll let the bug slide for a patch. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
