Quoting Chris Wilson (2020-04-30 12:18:18) > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c > index cb43381b0d37..da081401142e 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -219,6 +219,8 @@ int i915_gem_gtt_insert(struct i915_address_space *vm, > mode = DRM_MM_INSERT_HIGHEST; > if (flags & PIN_MAPPABLE) > mode = DRM_MM_INSERT_LOW; > + if (flags & PIN_NOSEARCH) > + mode = DRM_MM_INSERT_ONCE; Fortuitously only used in patch with DRM_MM_INSERT_BEST, so the mistake is not noticed, but it should be mode |= ONCE; Now the question is does CI notice this mistake? Unlikely. Could CI even notice? Unsure. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
