Re: [CI] drm/i915/gt: Apply the magic PM interval roundup to all!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chris,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip]
[cannot apply to v5.7-rc3 next-20200424]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-gt-Apply-the-magic-PM-interval-roundup-to-all/20200428-030319
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-a003-20200428 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   In file included from include/asm-generic/bug.h:5:0,
                    from arch/x86/include/asm/bug.h:83,
                    from include/linux/bug.h:5,
                    from include/linux/mmdebug.h:5,
                    from include/linux/gfp.h:5,
                    from include/linux/slab.h:15,
                    from include/linux/io-mapping.h:10,
                    from drivers/gpu/drm/i915/i915_drv.h:36,
                    from drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c:6:
   drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c: In function 'intel_gt_ns_to_pm_interval':
   drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c:99:29: error: 'MHZ_25' undeclared (first use in this function); did you mean 'MHZ_12_5'?
     if (gt->clock_frequency == MHZ_25)
                                ^
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
    #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                                       ^~~~
>> drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c:99:2: note: in expansion of macro 'if'
     if (gt->clock_frequency == MHZ_25)
     ^~
   drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c:99:29: note: each undeclared identifier is reported only once for each function it appears in
     if (gt->clock_frequency == MHZ_25)
                                ^
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
    #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                                       ^~~~
>> drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c:99:2: note: in expansion of macro 'if'
     if (gt->clock_frequency == MHZ_25)
     ^~

vim +/if +99 drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c

    85	
    86	u32 intel_gt_ns_to_pm_interval(const struct intel_gt *gt, u32 ns)
    87	{
    88		u32 val;
    89	
    90		val = DIV_ROUND_UP(intel_gt_ns_to_clock_interval(gt, ns), 16);
    91	
    92		/*
    93		 * Make these a multiple of magic 25 to avoid SNB (eg. Dell XPS
    94		 * 8300) freezing up around GPU hangs. Looks as if even
    95		 * scheduling/timer interrupts start misbehaving if the RPS
    96		 * EI/thresholds are "bad", leading to a very sluggish or even
    97		 * frozen machine.
    98		 */
  > 99		if (gt->clock_frequency == MHZ_25)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux