>-----Original Message----- >From: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> >Sent: Friday, April 17, 2020 3:55 PM >To: Ruhl, Michael J <michael.j.ruhl@xxxxxxxxx>; intel- >gfx@xxxxxxxxxxxxxxxxxxxxx >Subject: Re: [PATCH v2] drm/i915: Refactor setting dma info to a >common helper > >Quoting Michael J. Ruhl (2020-04-17 20:51:07) >> DMA_MASK bit values are different for different generations. >> >> This will become more difficult to manage over time with the open >> coded usage of different versions of the device. >> >> Fix by: >> disallow setting of dma mask in AGP path (< GEN(5) for i915, >> add dma_mask_size to the device info configuration, >> updating open code call sequence to the latest interface, >> refactoring into a common function for setting the dma segment >> and mask info >> >> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> >> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@xxxxxxxxx> >> cc: Brian Welty <brian.welty@xxxxxxxxx> >> cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> >> >> --- >> v1: removed i915 depenancy from agp path for dma mask >> Consolidated segment size and work arounds to the helper >> v2: added r-b > >You don't need to resend for adding r-b by itself, patchwork will do >that, and the committer should be checking the output from pw. dim then >double checks that we haven't missed anything vital. Cool. I will refrain from future sends. 😊 M >-Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
