Re: [PATCH 3/4] drm/i915: Push TRANS_DDI_FUNC_CTL into the encoder->enable() hook

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Ville Syrjala (2020-04-17 14:47:19)
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> 
> Push the TRANS_DDI_FUNC_CTL into the encoder enable hook. The disable
> is already there, and as a followup will enable us to pass the encoder
> all the way down.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>

In intel_ddi_transcoder_func_reg_val_get() I found a list of ddi
crtc types (HDMI, ANALOG, DP_MST, DP_SST). Now hdmi/dp == ddi, and so we
are left with dp_mst and crt callbacks.

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Is it possible to have more BUG_ON(!transcoder_is_ddi()) scatter around
the entry points?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux