>-----Original Message----- >From: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> >Sent: Friday, April 17, 2020 11:43 AM >To: Ruhl, Michael J <michael.j.ruhl@xxxxxxxxx>; intel- >gfx@xxxxxxxxxxxxxxxxxxxxx >Subject: Re: [PATCH] drm/i915: Refactor dma mask usage to a >common helper > >Quoting Michael J. Ruhl (2020-04-17 16:22:44) >> DMA_MASK bit values are different for different generations. >> >> This will become more difficult to manage over time with the open >> coded usage of different versions of the device. >> >> Fix by: >> adding dma_mask_size to the device info configuration, >> updating open code call sequence to the latest interface, >> refactoring into a common function for setting the dma_mask >> >> Note: GEN(5) and down is also set in intel_gmch_probe(). > >Assume we pull that code into i915.ko, we will one day. The gen5 stuff has the same dma_mask_size that I added to the i915 config structures. I thought about pulling it out of the gen 5 area, but it appears that that can be built as a separate driver, and if I pulled it out, the ability for it to be set in that path would be lost. M >-Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
