Re: [PATCH] drm/i915/gt: Scrub execlists state on resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Tvrtko Ursulin (2020-04-17 13:09:52)
> 
> On 16/04/2020 12:41, Chris Wilson wrote:
> > Before we resume, we reset the HW so we restart from a known good state.
> > However, as a part of the reset process, we drain our pending CS event
> > queue -- and if we are resuming that does not correspond to internal
> > state. On setup, we are scrubbing the CS pointers, but alas only on
> > setup.
> > 
> > Apply the sanitization not just to setup, but to all resumes.
> > 
> > Reported-by: Venkata Ramana Nayana <venkata.ramana.nayana@xxxxxxxxx>
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Venkata Ramana Nayana <venkata.ramana.nayana@xxxxxxxxx>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> > Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
> > ---
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

Tvrtko mentioned on irc that we could do some poisoning of assumed state
(like the HWSP here) in order to better catch these errors.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux