On Tue, Apr 14, 2020 at 01:32:49PM +0300, Kai Vehmanen wrote: > Hey, > > On Thu, 9 Apr 2020, Ville Syrjälä wrote: > > > On Thu, Apr 09, 2020 at 05:14:01PM +0300, Kai Vehmanen wrote: > > > type of content free ping, but I still dare to seek your input on what is > > > the proper way to get attention to a patch that are seemingly forever > > > stuck on the review sideline. > > > > And what is this? > > https://patchwork.freedesktop.org/patch/347148/?series=71527&rev=1 > > that's a lost child I'm afraid. It's essentially the same patch I > submitted late last year. It got review ok from Matt, and I thought it was > going to be merged and went on to do other things -- i.e. I failed to > follow-up on this. Back then I did not know about any actual bugs this > would fix -- this was a generic change to align with hw specs. > > Fast forward two months. I had forgotten about that previous patch, and > I ended up recreating the same patch to fix an actual bug. I.e. the of > this thread: > https://patchwork.freedesktop.org/series/74664/ OK. I sucked in the rb from the old patch and pushed the new version. Thanks. > > I only very recently noticed the old patch. But alas, the new attempt > is probably the one that should be merged as it has more information in > the commit message (we now know about actual issues on JSL). > > > Just ping on original patch or ping someone on irc. Resending > > the same patch over and over does no good. At least my brain just > > ignores anything that looks like it's just a resend w/o any clear > > justification. > > Ack, thanks a lot, this clarifies. In any case, patch author should own > the follow-up and I definitely dropped the ball on the older #347148 . > > Br, Kai -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
