On Wed, Apr 08, 2020 at 09:02:07AM +0200, Sam Ravnborg wrote:
> On Fri, Apr 03, 2020 at 03:57:47PM +0200, Daniel Vetter wrote:
> > We've had lots of conversions to embeddeding, but didn't stop using
> > ->dev_private. Which defeats the point of this.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
Went right ahead and pushed this since a doc patch only, thanks for taking
a look!
-Daniel
> > ---
> > include/drm/drm_device.h | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/drm/drm_device.h b/include/drm/drm_device.h
> > index d39132b477dd..a55874db9dd4 100644
> > --- a/include/drm/drm_device.h
> > +++ b/include/drm/drm_device.h
> > @@ -88,9 +88,12 @@ struct drm_device {
> > /**
> > * @dev_private:
> > *
> > - * DRM driver private data. Instead of using this pointer it is
> > - * recommended that drivers use drm_dev_init() and embed struct
> > - * &drm_device in their larger per-device structure.
> > + * DRM driver private data. This is deprecated and should be left set to
> > + * NULL.
> > + *
> > + * Instead of using this pointer it is recommended that drivers use
> > + * drm_dev_init() and embed struct &drm_device in their larger
> > + * per-device structure.
> > */
> > void *dev_private;
> >
> > --
> > 2.25.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
