[drm-tip:drm-tip 6/8] drivers/rtc/rtc-cmos.c:655:16: error: redefinition of 'flags'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
head:   636ab52e6d1d7aced9620f16da90d4c3c5fcadf5
commit: 213a0a26eba646607e88120c3fd27dc32b03e1f0 [6/8] Merge remote-tracking branch 'drm-intel/topic/core-for-CI' into drm-tip
config: x86_64-defconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 8e2daa0c7f27b5d13b11bff68ae3cd42329abd6c)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 213a0a26eba646607e88120c3fd27dc32b03e1f0
        # save the attached .config to linux build tree
        COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/rtc/rtc-cmos.c:655:16: error: redefinition of 'flags'
           unsigned long   flags;
                           ^
   drivers/rtc/rtc-cmos.c:652:16: note: previous definition is here
           unsigned long   flags;
                           ^
   1 error generated.

vim +/flags +655 drivers/rtc/rtc-cmos.c

7be2c7c96aff28 David Brownell 2007-02-10  649  
7be2c7c96aff28 David Brownell 2007-02-10  650  static irqreturn_t cmos_interrupt(int irq, void *p)
7be2c7c96aff28 David Brownell 2007-02-10  651  {
66e4f4a9cc389b Ville Syrjälä  2020-02-21  652  	unsigned long	flags;
7be2c7c96aff28 David Brownell 2007-02-10  653  	u8		irqstat;
8a0bdfd7a05f5b David Brownell 2008-02-06  654  	u8		rtc_control;
5b39064d452ac9 Chris Wilson   2020-03-02 @655  	unsigned long	flags;
7be2c7c96aff28 David Brownell 2007-02-10  656  
66e4f4a9cc389b Ville Syrjälä  2020-02-21  657  	spin_lock_irqsave(&rtc_lock, flags);
35d3fdd5f304c0 David Brownell 2008-07-23  658  
35d3fdd5f304c0 David Brownell 2008-07-23  659  	/* When the HPET interrupt handler calls us, the interrupt
35d3fdd5f304c0 David Brownell 2008-07-23  660  	 * status is passed as arg1 instead of the irq number.  But
35d3fdd5f304c0 David Brownell 2008-07-23  661  	 * always clear irq status, even when HPET is in the way.
35d3fdd5f304c0 David Brownell 2008-07-23  662  	 *
35d3fdd5f304c0 David Brownell 2008-07-23  663  	 * Note that HPET and RTC are almost certainly out of phase,
35d3fdd5f304c0 David Brownell 2008-07-23  664  	 * giving different IRQ status ...
9d8af78b07976d Bernhard Walle 2008-02-06  665  	 */
7be2c7c96aff28 David Brownell 2007-02-10  666  	irqstat = CMOS_READ(RTC_INTR_FLAGS);
8a0bdfd7a05f5b David Brownell 2008-02-06  667  	rtc_control = CMOS_READ(RTC_CONTROL);
311ee9c151ad7f Zhang Rui      2018-03-26  668  	if (use_hpet_alarm())
35d3fdd5f304c0 David Brownell 2008-07-23  669  		irqstat = (unsigned long)irq & 0xF0;
998a06051afe6c Derek Basehore 2013-07-03  670  
998a06051afe6c Derek Basehore 2013-07-03  671  	/* If we were suspended, RTC_CONTROL may not be accurate since the
998a06051afe6c Derek Basehore 2013-07-03  672  	 * bios may have cleared it.
998a06051afe6c Derek Basehore 2013-07-03  673  	 */
998a06051afe6c Derek Basehore 2013-07-03  674  	if (!cmos_rtc.suspend_ctrl)
8a0bdfd7a05f5b David Brownell 2008-02-06  675  		irqstat &= (rtc_control & RTC_IRQMASK) | RTC_IRQF;
998a06051afe6c Derek Basehore 2013-07-03  676  	else
998a06051afe6c Derek Basehore 2013-07-03  677  		irqstat &= (cmos_rtc.suspend_ctrl & RTC_IRQMASK) | RTC_IRQF;
8a0bdfd7a05f5b David Brownell 2008-02-06  678  
8a0bdfd7a05f5b David Brownell 2008-02-06  679  	/* All Linux RTC alarms should be treated as if they were oneshot.
8a0bdfd7a05f5b David Brownell 2008-02-06  680  	 * Similar code may be needed in system wakeup paths, in case the
8a0bdfd7a05f5b David Brownell 2008-02-06  681  	 * alarm woke the system.
8a0bdfd7a05f5b David Brownell 2008-02-06  682  	 */
8a0bdfd7a05f5b David Brownell 2008-02-06  683  	if (irqstat & RTC_AIE) {
998a06051afe6c Derek Basehore 2013-07-03  684  		cmos_rtc.suspend_ctrl &= ~RTC_AIE;
8a0bdfd7a05f5b David Brownell 2008-02-06  685  		rtc_control &= ~RTC_AIE;
8a0bdfd7a05f5b David Brownell 2008-02-06  686  		CMOS_WRITE(rtc_control, RTC_CONTROL);
311ee9c151ad7f Zhang Rui      2018-03-26  687  		if (use_hpet_alarm())
35d3fdd5f304c0 David Brownell 2008-07-23  688  			hpet_mask_rtc_irq_bit(RTC_AIE);
8a0bdfd7a05f5b David Brownell 2008-02-06  689  		CMOS_READ(RTC_INTR_FLAGS);
8a0bdfd7a05f5b David Brownell 2008-02-06  690  	}
66e4f4a9cc389b Ville Syrjälä  2020-02-21  691  	spin_unlock_irqrestore(&rtc_lock, flags);
7be2c7c96aff28 David Brownell 2007-02-10  692  
bcd9b89c02295b David Brownell 2007-04-01  693  	if (is_intr(irqstat)) {
7be2c7c96aff28 David Brownell 2007-02-10  694  		rtc_update_irq(p, 1, irqstat);
7be2c7c96aff28 David Brownell 2007-02-10  695  		return IRQ_HANDLED;
7be2c7c96aff28 David Brownell 2007-02-10  696  	} else
7be2c7c96aff28 David Brownell 2007-02-10  697  		return IRQ_NONE;
7be2c7c96aff28 David Brownell 2007-02-10  698  }
7be2c7c96aff28 David Brownell 2007-02-10  699  

:::::: The code at line 655 was first introduced by commit
:::::: 5b39064d452ac9739d59c5183c8a7c90a5982acb rtc/cmos: Protect rtc_lock from interrupts

:::::: TO: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
:::::: CC: Jani Nikula <jani.nikula@xxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux