On Mon, 2020-03-30 at 18:22 +0300, Imre Deak wrote: > The DDI IO power well must not be enabled for a TypeC port in TBT > mode, > ensure this during driver loading/system resume. > > This gets rid of error messages like > [drm] *ERROR* power well DDI E TC2 IO state mismatch (refcount > 1/enabled 0) > > and avoids leaking the power ref when disabling the output. Matches intel_ddi_post_disable_dp and tgl_ddi_pre_enable_dp/hsw_ddi_pre_enable_dp. Reviewed-by: José Roberto de Souza <jose.souza@xxxxxxxxx> > > Cc: <stable@xxxxxxxxxxxxxxx> # v5.4+ > Signed-off-by: Imre Deak <imre.deak@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c > b/drivers/gpu/drm/i915/display/intel_ddi.c > index 916a802af788..654151d9a6db 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -1899,7 +1899,11 @@ static void intel_ddi_get_power_domains(struct > intel_encoder *encoder, > return; > > dig_port = enc_to_dig_port(encoder); > - intel_display_power_get(dev_priv, dig_port- > >ddi_io_power_domain); > + > + if (!intel_phy_is_tc(dev_priv, phy) || > + dig_port->tc_mode != TC_PORT_TBT_ALT) > + intel_display_power_get(dev_priv, > + dig_port->ddi_io_power_domain); > > /* > * AUX power is only needed for (e)DP mode, and for HDMI mode > on TC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
