Hi again, Chris, > > @@ -622,7 +623,14 @@ void intel_rc6_park(struct intel_rc6 *rc6) > > > > /* Turn off the HW timers and go directly to rc6 */ > > set(uncore, GEN6_RC_CONTROL, GEN6_RC_CTL_RC6_ENABLE); > > - set(uncore, GEN6_RC_STATE, 0x4 << RC_SW_TARGET_STATE_SHIFT); > > + > > + if (HAS_RC6pp(rc6_to_i915(rc6))) > > + target = 0x6; /* deepest rc6 */ > > + else if (HAS_RC6p(rc6_to_i915(rc6))) > > + target = 0x5; /* deep rc6 */ > > + else > > + target = 0x4; /* normal rc6 */ > > can we put names to these values? actually, you are using these only here and there is a comment to them... givinb those values a meaningful define is a bit of a formality, I'd say. It's up to you. Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxx> Thanks, Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
