== Series Details == Series: drm/i915: Port sync for skl+ (rev3) URL : https://patchwork.freedesktop.org/series/74691/ State : warning == Summary == $ dim checkpatch origin/drm-tip 72dac032db0d drm/i915/mst: Use .compute_config_late() to compute master transcoder 0124ef44a60a drm/i915: Move TRANS_DDI_FUNC_CTL2 programming where it belongs 7200689fa007 drm/i915: Drop usless master_transcoder assignments aebcfc348cec drm/i915: Move icl_get_trans_port_sync_config() into the DDI code 6f316fb900f8 drm/i915: Use REG_FIELD_PREP() & co. for TRANS_DDI_FUNC_CTL2 -:55: WARNING:LONG_LINE: line over 100 characters #55: FILE: drivers/gpu/drm/i915/i915_reg.h:9734: +#define PORT_SYNC_MODE_MASTER_SELECT(x) REG_FIELD_PREP(PORT_SYNC_MODE_MASTER_SELECT_MASK, (x)) total: 0 errors, 1 warnings, 0 checks, 34 lines checked e832ccd1183a drm/i915: Include port sync state in the state dump 248ad2bd291b drm/i915: Store cpu_transcoder_mask in device info -:96: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #96: FILE: drivers/gpu/drm/i915/display/intel_display.h:323: +#define for_each_cpu_transcoder(__dev_priv, __t) \ for ((__t) = 0; (__t) < I915_MAX_TRANSCODERS; (__t)++) \ + for_each_if (INTEL_INFO(__dev_priv)->cpu_transcoder_mask & BIT(__t)) -:96: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__t' - possible side-effects? #96: FILE: drivers/gpu/drm/i915/display/intel_display.h:323: +#define for_each_cpu_transcoder(__dev_priv, __t) \ for ((__t) = 0; (__t) < I915_MAX_TRANSCODERS; (__t)++) \ + for_each_if (INTEL_INFO(__dev_priv)->cpu_transcoder_mask & BIT(__t)) -:99: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #99: FILE: drivers/gpu/drm/i915/display/intel_display.h:325: + for_each_if (INTEL_INFO(__dev_priv)->cpu_transcoder_mask & BIT(__t)) -:101: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #101: FILE: drivers/gpu/drm/i915/display/intel_display.h:327: +#define for_each_cpu_transcoder_masked(__dev_priv, __t, __mask) \ + for_each_cpu_transcoder(__dev_priv, __t) \ + for_each_if ((__mask) & BIT(__t)) -:101: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__t' - possible side-effects? #101: FILE: drivers/gpu/drm/i915/display/intel_display.h:327: +#define for_each_cpu_transcoder_masked(__dev_priv, __t, __mask) \ + for_each_cpu_transcoder(__dev_priv, __t) \ + for_each_if ((__mask) & BIT(__t)) -:103: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #103: FILE: drivers/gpu/drm/i915/display/intel_display.h:329: + for_each_if ((__mask) & BIT(__t)) -:116: WARNING:LONG_LINE: line over 100 characters #116: FILE: drivers/gpu/drm/i915/i915_drv.h:1605: +#define HAS_TRANSCODER(dev_priv, trans) ((INTEL_INFO(dev_priv)->cpu_transcoder_mask & BIT(trans)) != 0) total: 2 errors, 3 warnings, 2 checks, 242 lines checked 2084e75f8c82 drm/i915: Implement port sync for SKL+ -:209: WARNING:LONG_LINE: line over 100 characters #209: FILE: drivers/gpu/drm/i915/i915_reg.h:9704: +#define TRANS_DDI_PORT_SYNC_MASTER_SELECT(x) REG_FIELD_PREP(TRANS_DDI_PORT_SYNC_MASTER_SELECT_MASK, (x)) total: 0 errors, 1 warnings, 0 checks, 165 lines checked ed313611cd9d drm/i915: Eliminate port sync copy pasta a85031aa5231 drm/i915: Fix port sync code to work with >2 pipes 65906b744e8d drm/i915: Do pipe updates after enables for everyone ba9ff9562959 drm/i915: Pass atomic state to encoder hooks -:558: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_atomic_state *' should also have an identifier name #558: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:149: + void (*pre_pll_enable)(struct intel_atomic_state *, -:558: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_encoder *' should also have an identifier name #558: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:149: + void (*pre_pll_enable)(struct intel_atomic_state *, -:558: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct intel_crtc_state *' should also have an identifier name #558: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:149: + void (*pre_pll_enable)(struct intel_atomic_state *, -:558: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct drm_connector_state *' should also have an identifier name #558: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:149: + void (*pre_pll_enable)(struct intel_atomic_state *, -:563: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_atomic_state *' should also have an identifier name #563: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:153: + void (*pre_enable)(struct intel_atomic_state *, -:563: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_encoder *' should also have an identifier name #563: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:153: + void (*pre_enable)(struct intel_atomic_state *, -:563: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct intel_crtc_state *' should also have an identifier name #563: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:153: + void (*pre_enable)(struct intel_atomic_state *, -:563: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct drm_connector_state *' should also have an identifier name #563: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:153: + void (*pre_enable)(struct intel_atomic_state *, -:568: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_atomic_state *' should also have an identifier name #568: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:157: + void (*enable)(struct intel_atomic_state *, -:568: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_encoder *' should also have an identifier name #568: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:157: + void (*enable)(struct intel_atomic_state *, -:568: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct intel_crtc_state *' should also have an identifier name #568: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:157: + void (*enable)(struct intel_atomic_state *, -:568: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct drm_connector_state *' should also have an identifier name #568: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:157: + void (*enable)(struct intel_atomic_state *, -:576: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_atomic_state *' should also have an identifier name #576: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:164: + void (*disable)(struct intel_atomic_state *, -:576: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_encoder *' should also have an identifier name #576: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:164: + void (*disable)(struct intel_atomic_state *, -:576: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct intel_crtc_state *' should also have an identifier name #576: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:164: + void (*disable)(struct intel_atomic_state *, -:576: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct drm_connector_state *' should also have an identifier name #576: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:164: + void (*disable)(struct intel_atomic_state *, -:581: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_atomic_state *' should also have an identifier name #581: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:168: + void (*post_disable)(struct intel_atomic_state *, -:581: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_encoder *' should also have an identifier name #581: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:168: + void (*post_disable)(struct intel_atomic_state *, -:581: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct intel_crtc_state *' should also have an identifier name #581: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:168: + void (*post_disable)(struct intel_atomic_state *, -:581: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct drm_connector_state *' should also have an identifier name #581: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:168: + void (*post_disable)(struct intel_atomic_state *, -:586: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_atomic_state *' should also have an identifier name #586: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:172: + void (*post_pll_disable)(struct intel_atomic_state *, -:586: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_encoder *' should also have an identifier name #586: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:172: + void (*post_pll_disable)(struct intel_atomic_state *, -:586: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct intel_crtc_state *' should also have an identifier name #586: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:172: + void (*post_pll_disable)(struct intel_atomic_state *, -:586: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct drm_connector_state *' should also have an identifier name #586: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:172: + void (*post_pll_disable)(struct intel_atomic_state *, -:591: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_atomic_state *' should also have an identifier name #591: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:176: + void (*update_pipe)(struct intel_atomic_state *, -:591: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_encoder *' should also have an identifier name #591: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:176: + void (*update_pipe)(struct intel_atomic_state *, -:591: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct intel_crtc_state *' should also have an identifier name #591: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:176: + void (*update_pipe)(struct intel_atomic_state *, -:591: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct drm_connector_state *' should also have an identifier name #591: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:176: + void (*update_pipe)(struct intel_atomic_state *, total: 0 errors, 28 warnings, 0 checks, 1136 lines checked eea643cabc5f drm/i915: Move the port sync DP_TP_CTL stuff to the encoder hook _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
