Re: [PATCH v19 3/8] drm/i915: Add intel_bw_get_*_state helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 13, 2020 at 01:57:58PM +0000, Lisovskiy, Stanislav wrote:
> >> >> Add correspondent helpers to be able to get old/new bandwidth
> >> >> global state object.
> >> >>
> >> >> v2: - Fixed typo in function call
> >> >> v3: - Changed new functions naming to use convention proposed
> >> >>       by Jani Nikula, i.e intel_bw_* in intel_bw.c file.
> >>
> >> >Still nak on the rename.
> >>
> >> Cool. Discuss it with Jani Nikula then, to have at least some common strategy on how to be picky on me.
> 
> >The strategy is either rename all of these functions or none so that we
> >don't end up with random inconsistencies all over the place.
> 
> 
> Initially Jani Nikula wrote that he is trying to encourage people to call functions
> 
> starting with the module name. OK. Done it.
> 
> 
> You say that the opposite and nack. Now it just turns out that it is again _me_ - poor minded, who didn't understand that I need to rename
> 
> all functions now here as well, including those completely unrelated to that patch.
> 
> Sure - we have "plenty" of time!
> 
> 
> Or may be I shouldn't rename - kind of confused now.

If you do a mass rename do it as a separate series.

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux