== Series Details == Series: Per client engine busyness (rev6) URL : https://patchwork.freedesktop.org/series/70977/ State : warning == Summary == $ dim checkpatch origin/drm-tip 29248a8e5b5b drm/i915: Expose list of clients in sysfs -:74: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #74: new file mode 100644 -:79: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #79: FILE: drivers/gpu/drm/i915/i915_drm_client.c:1: +/* -:80: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #80: FILE: drivers/gpu/drm/i915/i915_drm_client.c:2: + * SPDX-License-Identifier: MIT -:93: CHECK:LINE_SPACING: Please don't use multiple blank lines #93: FILE: drivers/gpu/drm/i915/i915_drm_client.c:15: + + -:128: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name #128: FILE: drivers/gpu/drm/i915/i915_drm_client.c:50: + ssize_t (*show)(struct device *, -:128: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device_attribute *' should also have an identifier name #128: FILE: drivers/gpu/drm/i915/i915_drm_client.c:50: + ssize_t (*show)(struct device *, -:266: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #266: FILE: drivers/gpu/drm/i915/i915_drm_client.h:1: +/* -:267: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #267: FILE: drivers/gpu/drm/i915/i915_drm_client.h:2: + * SPDX-License-Identifier: MIT total: 0 errors, 7 warnings, 1 checks, 373 lines checked 777e2a3516c5 drm/i915: Update client name on context create -:158: ERROR:OPEN_BRACE: open brace '{' following struct go on the same line #158: FILE: drivers/gpu/drm/i915/i915_drm_client.c:198: +struct client_update_free +{ -:200: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message #200: FILE: drivers/gpu/drm/i915/i915_drm_client.c:240: + if (!name) { + drm_notice(&i915->drm, -:242: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #242: FILE: drivers/gpu/drm/i915/i915_drm_client.h:31: + struct mutex update_lock; total: 1 errors, 1 warnings, 1 checks, 204 lines checked 3a15cdb16e80 drm/i915: Make GEM contexts track DRM clients f713946e1547 drm/i915: Use explicit flag to mark unreachable intel_context 04e9160d2ca7 drm/i915: Track runtime spent in unreachable intel_contexts dfd6ab343b76 drm/i915: Track runtime spent in closed GEM contexts bac56c86f3da drm/i915: Track all user contexts per client -:89: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #89: FILE: drivers/gpu/drm/i915/i915_drm_client.h:42: + spinlock_t ctx_lock; total: 0 errors, 0 warnings, 1 checks, 59 lines checked c0ad445d4bee drm/i915: Expose per-engine client busyness -:25: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #25: Render/3D/0 63.73% |███████████████████ | 3% 0% -:114: WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const #114: FILE: drivers/gpu/drm/i915/i915_drm_client.c:101: +static const char *uabi_class_names[] = { total: 0 errors, 2 warnings, 0 checks, 164 lines checked 633b5089141d drm/i915: Track context current active time -:138: WARNING:LINE_SPACING: Missing a blank line after declarations #138: FILE: drivers/gpu/drm/i915/gt/intel_context_types.h:87: + u32 last; + I915_SELFTEST_DECLARE(u32 num_underflow); total: 0 errors, 1 warnings, 0 checks, 240 lines checked 03ee993cda5e drm/i915: Prefer software tracked context busyness _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
